Dockerfile: use alpine 3.12 #15950
Merged
Dockerfile: use alpine 3.12 #15950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
release-note/misc
sayboras
reviewed
Apr 29, 2021
aanm
force-pushed
the
pr/fix-alpine
branch
2 times, most recently
from
fa12000
to
36252c6
Compare
|
test-me-please |
In Alpine 3.11 and 3.13, 'nslookup' exits with the error code 1 if it can't resolve all IPs for the search list defined in /etc/resolv.conf However, it seems that Alpine 3.10 and 3.12 are not affected by this bug and continue return the error code 0 if at least on of the domains in the search list is resolved into an IP address. Thus, we will use the latest Alpine image available for the 3.12 release series. Signed-off-by: André Martins <andre@cilium.io>
|
test-me-please |
|
test-gke (K8sServicesTest Checks service across nodes Supports IPv4 fragments) |
|
ci-multicluster |
|
test-gke |
rolinh
approved these changes
May 3, 2021
qmonnet
approved these changes
May 4, 2021
nebril
approved these changes
May 5, 2021
| @@ -2,8 +2,8 @@ apiVersion: v2 | |||
| name: cilium | |||
| displayName: Cilium | |||
| home: https://cilium.io/ | |||
| version: 1.9.90 | |||
| appVersion: 1.9.90 | |||
| version: 1.10.90 | |||
There was a problem hiding this comment.
shouldn't this be 1.11.90 for master?
There was a problem hiding this comment.
No, it's 1.10.90 as we haven't released 1.11 yet. See it as the 90 is between 1.10.x and 1.11.0
borkmann
approved these changes
May 5, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
aanm
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.0-rc2
tklauser
added a commit
that referenced
this pull request
Jul 4, 2022
Since alpine 3.12 is EOL and was recently dropped from docker official images [1], update our images to alpine 3.16.0 which is currently the most recent version. [1] docker-library/official-images#12477 The comment about nslookup stems from PR #15950, but none of the images seem to use nslookup. We only use these images for ca-certificates and python/bash, respectively. Signed-off-by: Tobias Klauser <tobias@cilium.io>
qmonnet
pushed a commit
that referenced
this pull request
Jul 6, 2022
Since alpine 3.12 is EOL and was recently dropped from docker official images [1], update our images to alpine 3.16.0 which is currently the most recent version. [1] docker-library/official-images#12477 The comment about nslookup stems from PR #15950, but none of the images seem to use nslookup. We only use these images for ca-certificates and python/bash, respectively. Signed-off-by: Tobias Klauser <tobias@cilium.io>
ldelossa
pushed a commit
to ldelossa/cilium
that referenced
this pull request
Jul 13, 2022
[ upstream commit 7e07d55 ] Since alpine 3.12 is EOL and was recently dropped from docker official images [1], update our images to alpine 3.16.0 which is currently the most recent version. [1] docker-library/official-images#12477 The comment about nslookup stems from PR cilium#15950, but none of the images seem to use nslookup. We only use these images for ca-certificates and python/bash, respectively. Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
aanm
pushed a commit
that referenced
this pull request
Jul 14, 2022
[ upstream commit 7e07d55 ] Since alpine 3.12 is EOL and was recently dropped from docker official images [1], update our images to alpine 3.16.0 which is currently the most recent version. [1] docker-library/official-images#12477 The comment about nslookup stems from PR #15950, but none of the images seem to use nslookup. We only use these images for ca-certificates and python/bash, respectively. Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
gandro
pushed a commit
to gandro/cilium
that referenced
this pull request
Aug 4, 2022
[ upstream commit 7e07d55 ] Since alpine 3.12 is EOL and was recently dropped from docker official images [1], update our images to alpine 3.16.0 which is currently the most recent version. [1] docker-library/official-images#12477 The comment about nslookup stems from PR cilium#15950, but none of the images seem to use nslookup. We only use these images for ca-certificates and python/bash, respectively. Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
dezmodue
pushed a commit
to dezmodue/cilium
that referenced
this pull request
Aug 10, 2022
Since alpine 3.12 is EOL and was recently dropped from docker official images [1], update our images to alpine 3.16.0 which is currently the most recent version. [1] docker-library/official-images#12477 The comment about nslookup stems from PR cilium#15950, but none of the images seem to use nslookup. We only use these images for ca-certificates and python/bash, respectively. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Alpine 3.11 and 3.13, 'nslookup' exits with the error code 1 if it
can't resolve all IPs for the search list defined in /etc/resolv.conf
However, it seems that Alpine 3.10 and 3.12 are not affected by this bug
and continue return the error code 0 if at least on of the domains in
the search list is resolved into an IP address. Thus, we will use the
latest Alpine image available for the 3.12 release series.
Signed-off-by: André Martins andre@cilium.io