Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: gsg/operations - use parsed-literal for all blocks referring SCM_WEB #15963

Merged
merged 1 commit into from Apr 30, 2021
Merged

docs: gsg/operations - use parsed-literal for all blocks referring SCM_WEB #15963

merged 1 commit into from Apr 30, 2021

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Apr 30, 2021

Found these SCM_WEB rendered verbatim in the docs. Checked the HTML output of the build, and couldn't find any other SCM_ or _RELEASE variables in the HTML output.

@ti-mo
docs: gsg/operations - use parsed-literal for all blocks referring SC…
6919195 
…M_WEB

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo requested a review from a team as a code owner April 30, 2021 12:45
@ti-mo ti-mo requested a review from qmonnet April 30, 2021 12:45
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 30, 2021
@ti-mo ti-mo added the release-note/misc This PR makes changes that have no direct user impact. label Apr 30, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 30, 2021
qmonnet
qmonnet approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@qmonnet qmonnet removed their assignment Apr 30, 2021
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 30, 2021
@rolinh rolinh merged commit 63c1e92 into cilium:master Apr 30, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 Apr 30, 2021
@ti-mo ti-mo deleted the tb/parsed-literal-fixes branch May 3, 2021 09:11
@brb brb mentioned this pull request May 7, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@aanm aanm mentioned this pull request May 17, 2021
Merged
@bmcustodio bmcustodio mentioned this pull request May 17, 2021
Merged
@aanm aanm mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ti-mo @qmonnet @brb @joestringer @rolinh