docs: update OpenShift getting started guide #16006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpayne
added
area/documentation
twpayne
force-pushed
the
pr/twpayne/openshift-gsg
branch
from
1669832
to
49ff829
Compare
qmonnet
requested changes
May 4, 2021
twpayne
force-pushed
the
pr/twpayne/openshift-gsg
branch
from
49ff829
to
8288fc9
Compare
|
Thanks, PR updated. I've updated all code blocks to use |
|
|
||
| .. note:: | ||
| ls "${CLUSTER_NAME}/manifests/cluster-network-*-cilium-*" |
There was a problem hiding this comment.
double quotes turn * into a literal character, so the glob won't expand...
There was a problem hiding this comment.
I don't think they do, single-quotes do that
There was a problem hiding this comment.
I think Ilya is right, try ls "*".
There was a problem hiding this comment.
🤯 I could've have sworn that bash would expand the glob...sorry folks 😅
christarazi
approved these changes
May 6, 2021
qmonnet
requested changes
May 7, 2021
twpayne
force-pushed
the
pr/twpayne/openshift-gsg
branch
from
8288fc9
to
56c6433
Compare
* Correct some minor errors in scripts. * Update openshift-install output for latest stable version. * Add instructions on how to delete the cluster. * Minor grammatical tweaks. * Minor formatting tweaks. Signed-off-by: Tom Payne <tom@isovalent.com>
twpayne
force-pushed
the
pr/twpayne/openshift-gsg
branch
from
56c6433
to
a4b7645
Compare
qmonnet
approved these changes
May 10, 2021
qmonnet
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.0-rc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Payne tom@isovalent.com