Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix a block directive in OpenShift GSG #17760

Merged
merged 1 commit into from Nov 4, 2021

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Nov 2, 2021

A previous commit aimed at cleaning up the guide for OpenShift, but it wrongly turned a parsed-literal block into a code-block, dropping the evaluation of the |release| substitution. Let's restore it.

This also requires us to tell the RST linter that the |release| substitution is valid.

Fixes: #16006

A previous commit aimed at cleaning up the guide for OpenShift, but it
wrongly turned a "parsed-literal" block into a "code-block", dropping
the evaluation of the "|release|" substitution. Let's restore it.

This also requires us to tell the RST linter that the "|release|"
substitution is valid.

Fixes: 421314d ("docs: update OpenShift getting started guide")
Reported-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Nov 2, 2021
@qmonnet qmonnet requested a review from a team as a code owner November 2, 2021 16:40
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.6 Nov 2, 2021
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 2, 2021
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out @qmonnet!

@nathanjsweet nathanjsweet merged commit 9a3ba01 into cilium:master Nov 4, 2021
@qmonnet qmonnet deleted the pr/os-parsed-literal branch November 5, 2021 09:24
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.6 Nov 12, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.6 Nov 12, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.6 Nov 23, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.6 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.6
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

6 participants