docs: add 'endpointRoutes.enabled=true' to aws-cni #16045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
This is meant as a temporary workaround for #16007. Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
pchaigno
added
area/documentation
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
May 7, 2021
qmonnet
approved these changes
May 7, 2021
joestringer
approved these changes
May 7, 2021
There was a problem hiding this comment.
I'm a little bit nervous that maybe we used to always automatically configure this for chaining mode and somehow we accidentally changed something so that it's not automatic any more (and also implicitly this could mean that for other chaining plugins it's still a problem), but at the same time this seems like an easy workaround for now.
👍
|
If we think this is also a problem on v1.8.x, we should backport it there too so we can point to the docs and make sure folks are configuring this option. |
|
I spoke too soon. The PR that introduced this regression for chaining mode (i.e., #15228) wasn't backported to v1.8 so we don't need to backport there either. |
jrajahalme
approved these changes
May 7, 2021
tgraf
approved these changes
May 11, 2021
pchaigno
added
the
ready-to-merge
nathanjsweet
approved these changes
May 11, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.0-rc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant as a temporary workaround for #16007.