test: Use hubble observe's jsonpb output in artifacts #16054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubble observe now supports [1] reading flows from stdin if they are in jsonpb format. We should therefore emit jsonpb artifact files for tests, to be able to feed those files back into hubble observe. That will allow us to use hubble observe's filters and different output format. 1 - cilium/hubble#524 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/CI-improvement
pchaigno
commented
May 7, 2021
pchaigno
changed the title
rolinh
approved these changes
May 10, 2021
nbusseneau
approved these changes
May 10, 2021
|
Hopefully a test will fail and allow us to validate this: |
|
k8s-1.19-kernel-5.4 failed with known flake #15455. I downloaded the artifact and checked the new Hubble files. All good. Marking as ready to merge since reviews are in. I'll also cancel the other builds. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hubble observenow supports [1] reading flows from stdin if they are in jsonpb format. We should therefore emit jsonpb artifact files for tests, to be able to feed those files back intohubble observe. That will allow us to usehubble observe's filters and different output format.1 - cilium/hubble#524