Support reading flows from stdin #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
michi-covalent
added
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
force-pushed
the
pr/michi/pipe
branch
from
c3de54b
to
3716cc2
Compare
michi-covalent
requested review from
rolinh,
glibsm,
gandro,
kaworu and
nathanjsweet
rolinh
requested changes
Apr 6, 2021
gandro
reviewed
Apr 6, 2021
reading from multiple files are already supported in a way. you can do: you can also pre-process files before sending to we could add positional arguments, but i thought it might get a bit more confusing to users. right now the separation is pretty clear i think: if stdin is a pipe, read flows from there. else connect to hubble server. |
michi-covalent
force-pushed
the
pr/michi/pipe
branch
2 times, most recently
from
b24842e
to
28754b2
Compare
rolinh
requested changes
Apr 7, 2021
Implement an ObserverClient that reads jsonpb flows from an io.Reader
instead of connecting to Hubble, and modify `hubble observe` command
to use it when stdin is a pipe. For example,
hubble observe -o jsonpb --last 1000 > flows.log
cat flows.log | hubble observe -n kube-system
A few things to note for observing flows from stdin:
- --follow, --last, and server flags are ignored.
- Flows are processed in the order they are read from stdin without
sorting them by timestamp.
Fixes #523
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/pipe
branch
from
28754b2
to
d03660c
Compare
rolinh
approved these changes
Apr 7, 2021
pchaigno
added a commit
to pchaigno/cilium
that referenced
this pull request
May 7, 2021
hubble observe now supports [1] reading flows from stdin if they are in jsonpb format. We should therefore emit jsonpb artifact files for tests, to be able to feed those files back into hubble observe. That will allow us to use hubble observe's filters and different output format. 1 - cilium/hubble#524 Signed-off-by: Paul Chaignon <paul@cilium.io>
ti-mo
pushed a commit
to cilium/cilium
that referenced
this pull request
May 10, 2021
hubble observe now supports [1] reading flows from stdin if they are in jsonpb format. We should therefore emit jsonpb artifact files for tests, to be able to feed those files back into hubble observe. That will allow us to use hubble observe's filters and different output format. 1 - cilium/hubble#524 Signed-off-by: Paul Chaignon <paul@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement an ObserverClient that reads jsonpb flows from an io.Reader
instead of connecting to Hubble, and modify
hubble observecommandto use it when stdin is a pipe. For example,
A few things to note for observing flows from stdin:
sorting them by timestamp.
Fixes #523
Signed-off-by: Michi Mutsuzaki michi@isovalent.com