Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add kube-proxy replacement known limitation #16139

Closed
wants to merge 1 commit into from

Conversation

aanm
Copy link
Member

@aanm aanm commented May 13, 2021

Signed-off-by: André Martins andre@cilium.io

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels May 13, 2021
@aanm aanm requested review from brb and borkmann May 13, 2021 12:50
@aanm aanm requested a review from a team as a code owner May 13, 2021 12:50
@aanm aanm requested review from a team and qmonnet May 13, 2021 12:50
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 13, 2021
.. attention::

When switching Cilium with kube-proxy replacement from enabled to disabled,
or vice-versa, existing connections in that node will be disrupted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to specify which exactly connections will be disrupted, as it reads that all connections will be disrupted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the quick start guide tells how to deploy a kube-proxy free version, and it will be using kpr=strict. I don't think we need to scare off users in here. This warning rather belongs into https://docs.cilium.io/en/v1.9/gettingstarted/kubeproxy-free/#kube-proxy-hybrid-modes where we talk about hybrid modes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to specify which exactly connections will be disrupted,

@brb Which are?

Also, the quick start guide tells how to deploy a kube-proxy free version, and it will be using kpr=strict. I don't think we need to scare off users in here.

@borkmann I'm not sure if I agree with that. The GSG recommends removing kube-proxy DS on running clusters:

For existing installations with kube-proxy running as a DaemonSet, remove it by using the following commands:

This gives the impression that it is fine to remove kube-proxy without any consequences which is not correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that part of the guide looks actually a bit broken.. I just did a general edit. Please see: #16169

@aanm aanm added this to Needs backport from master in 1.10.0-rc3 May 17, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc2 May 17, 2021
@borkmann
Copy link
Member

Fixed via #16169

@borkmann borkmann closed this May 17, 2021
@aanm aanm added this to Needs backport from master in 1.10.1 May 19, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc3 May 19, 2021
@aanm aanm added this to Needs backport from master in 1.10.2 Jun 16, 2021
@aanm aanm removed this from Needs backport from master in 1.10.1 Jun 16, 2021
@aanm aanm added this to Needs backport from master in 1.10.3 Jul 2, 2021
@aanm aanm removed this from Needs backport from master in 1.10.2 Jul 2, 2021
@aanm aanm added this to Needs backport from master in 1.10.4 Jul 15, 2021
@aanm aanm removed this from Needs backport from master in 1.10.3 Jul 15, 2021
@joestringer joestringer added this to Needs backport from master in 1.10.5 Sep 1, 2021
@joestringer joestringer removed this from Needs backport from master in 1.10.4 Sep 1, 2021
@joestringer joestringer removed this from Needs backport from master in 1.10.5 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants