-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add kube-proxy replacement known limitation #16139
Conversation
Signed-off-by: André Martins <andre@cilium.io>
.. attention:: | ||
|
||
When switching Cilium with kube-proxy replacement from enabled to disabled, | ||
or vice-versa, existing connections in that node will be disrupted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to specify which exactly connections will be disrupted, as it reads that all connections will be disrupted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the quick start guide tells how to deploy a kube-proxy free version, and it will be using kpr=strict. I don't think we need to scare off users in here. This warning rather belongs into https://docs.cilium.io/en/v1.9/gettingstarted/kubeproxy-free/#kube-proxy-hybrid-modes where we talk about hybrid modes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to specify which exactly connections will be disrupted,
@brb Which are?
Also, the quick start guide tells how to deploy a kube-proxy free version, and it will be using kpr=strict. I don't think we need to scare off users in here.
@borkmann I'm not sure if I agree with that. The GSG recommends removing kube-proxy DS on running clusters:
For existing installations with kube-proxy running as a DaemonSet, remove it by using the following commands:
This gives the impression that it is fine to remove kube-proxy
without any consequences which is not correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that part of the guide looks actually a bit broken.. I just did a general edit. Please see: #16169
Fixed via #16169 |
Signed-off-by: André Martins andre@cilium.io