Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs, gsg: minor edits to kpr guide and note on hybrid use #16169

Merged
merged 1 commit into from May 17, 2021
Merged

docs, gsg: minor edits to kpr guide and note on hybrid use #16169

merged 1 commit into from May 17, 2021

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented May 17, 2021 •
edited

See commit msg. overall doc suggestion, also supersedes #16139.

@borkmann borkmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/kube-proxy-free area/kube-proxy Issues related to kube-proxy (not the kube-proxy-free mode). labels May 17, 2021
@borkmann borkmann requested review from brb and aanm May 17, 2021 07:54
@borkmann borkmann requested a review from a team as a code owner May 17, 2021 07:54
@borkmann borkmann requested review from a team and joestringer May 17, 2021 07:54
@borkmann borkmann mentioned this pull request May 17, 2021
Closed
brb
brb approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

Documentation/gettingstarted/kubeproxy-free.rst Outdated Show resolved Hide resolved
@borkmann
docs, gsg: minor edits to kpr guide and note on hybrid use
e8097f9 
b2d2d69 ("docs: Add how to remove kube-proxy from existing clusters")
added the howto for removing kube-proxy right into the middle of the kubeadm
setup given right afterwards we talk about kubeadm join. Detangle this to
make it more clear that both don't have anything to do with each other.
Also add a warning to removing kube-proxy that this is disruptive.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 17, 2021
@tklauser tklauser merged commit 107fb8f into master May 17, 2021
@tklauser tklauser deleted the pr/kpr-doc branch May 17, 2021 11:13
@jrajahalme jrajahalme mentioned this pull request May 18, 2021
Merged
@vadorovsky vadorovsky mentioned this pull request May 19, 2021
Merged
@aanm aanm mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@tklauser tklauser tklauser approved these changes

@aanm aanm Awaiting requested review from aanm

@joestringer joestringer Awaiting requested review from joestringer

Assignees

@joestringer joestringer

@aanm aanm

Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/kube-proxy Issues related to kube-proxy (not the kube-proxy-free mode). ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@borkmann @brb @tklauser @twpayne @joestringer @aanm @jrajahalme @vadorovsky