Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: add back 'wellKnownIdentities' #16142

Merged
merged 1 commit into from May 19, 2021
Merged

helm: add back 'wellKnownIdentities' #16142

merged 1 commit into from May 19, 2021

Conversation

bmcustodio
Copy link
Contributor

This reverts commit 25f45b5. Some users rely on this functionality while using externally managed etcd clusters.

helm: add back 'wellKnownIdentities'

@bmcustodio bmcustodio requested review from a team as code owners May 13, 2021 16:46
@bmcustodio bmcustodio requested review from a team, qmonnet and kaworu May 13, 2021 16:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 13, 2021
@bmcustodio bmcustodio requested a review from brb May 13, 2021 16:46
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 13, 2021
@qmonnet qmonnet requested a review from joestringer May 13, 2021 17:09
@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 13, 2021
@aanm aanm added this to Needs backport from master in 1.10.0-rc3 May 17, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc2 May 17, 2021
@maintainer-s-little-helper
Copy link

Commit b9ff8de7c2913c8ea4d97a94e3b890f7ff805052 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 18, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.8 May 18, 2021
@bmcustodio
helm: add back 'wellKnownIdentities'
3ab9a84 
This reverts commit 25f45b5. Some users
rely on this functionality while using externally managed etcd clusters.

Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 18, 2021
@joestringer
Copy link
Member

Helm change only, no need to re-run CI.

@joestringer joestringer merged commit 50c0045 into cilium:master May 19, 2021
@bmcustodio bmcustodio deleted the bmcustodio-revert-25f45b5 branch May 19, 2021 07:20
@vadorovsky vadorovsky mentioned this pull request May 19, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.8 May 19, 2021
@aanm aanm added this to Needs backport from master in 1.10.1 May 19, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc3 May 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.8 May 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.8 May 21, 2021
@nbusseneau nbusseneau mentioned this pull request May 21, 2021
Merged
@aanm aanm moved this from Needs backport from master to Backport pending to v1.10 in 1.10.1 May 25, 2021
@aanm aanm added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels May 27, 2021
@aanm aanm mentioned this pull request May 28, 2021
Merged
@aanm aanm moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.1 Jun 16, 2021
@aanm aanm mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@brb brb brb approved these changes

@joestringer joestringer joestringer approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.10.1
Backport done to v1.10
1.9.8
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bmcustodio @joestringer @kaworu @brb @qmonnet @twpayne @nbusseneau @aanm @vadorovsky