workflows: various small fixes #16311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
added
area/CI
pchaigno
approved these changes
May 25, 2021
nbusseneau
force-pushed
the
pr/workflows-various-fixes
branch
from
a8e9768
to
37b904c
Compare
pchaigno
approved these changes
May 25, 2021
nbusseneau
force-pushed
the
pr/workflows-various-fixes
branch
2 times, most recently
from
8d4358a
to
309ff77
Compare
BeforeAfterCan't give you an after for |
aanm
requested changes
May 26, 2021
.github/workflows/images-legacy.yaml
Outdated
| @@ -171,7 +171,7 @@ jobs: | |||
| uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700 | |||
| with: | |||
| name: image-digest ${{ matrix.name }} | |||
| path: image-digest | |||
| path: image-digest/${{ matrix.name }}.txt | |||
There was a problem hiding this comment.
Can you clarify in the commit message what is wrong with the current path?
There was a problem hiding this comment.
Of course. You actually did well to ask me that because looking over it again: I think I made a mistake in my initial analysis.
I thought the upload artifacts was using the wrong path, which caused the warning here, but now I actually think the root cause is not the artifacts path but the fact we don't build artifacts for build-and-push-with-qemu for PR events, only for push events.
I pushed a more proper fix -- PTAL.
There was a problem hiding this comment.
For context following offline discussion:
build-and-push-with-qemubuildscilium-test, which is used by thenightly.yamlworkflow.- Nightly runs only a schedule, hence why the current setup in
images-legacy.yamlonly builds for pushes tomaster. - In the past, there was a nightly Jenkins job that could be triggered by
test-nightlyon PRs. It has since been marked as obsolete, probably when we moved nightly tests from Jenkins to GitHub, and removing the ability to test PRs in the process: https://jenkins.cilium.io/view/Obsolete/job/Cilium-PR-Nightly/
nbusseneau
force-pushed
the
pr/workflows-various-fixes
branch
3 times, most recently
from
fd40aff
to
421b5cc
Compare
nbusseneau
force-pushed
the
pr/workflows-various-fixes
branch
from
421b5cc
to
2670ae7
Compare
pchaigno
approved these changes
May 26, 2021
tklauser
approved these changes
May 27, 2021
The build-and-push-with-qemu job was split and copied from the above build-and-push-prs job, however it does not include building steps for PR events, but only for pushes to master. We rewrite the workflow to directly skip the build-and-push-with-qemu on PR branches and streamline it since we only consider push events. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
As documented here: https://github.com/dorny/paths-filter/blob/78ab00f87740f82aec8ed8826eb4c3c851044126/action.yml > This option is ignored if action is triggered by pull_request event. As for `${{ github.event.before }}`, it is undeeded for push events to `master`: > Defaults to repository default branch (e.g. master). They actually create a warning in GitHub actions, so I propose removing it. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
force-pushed
the
pr/workflows-various-fixes
branch
from
2670ae7
to
3a973ee
Compare
nebril
approved these changes
Jun 1, 2021
nebril
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits.