update .github directory to be v1.11 branch specific #17986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
the
release-note/misc
joestringer
approved these changes
Nov 23, 2021
nbusseneau
approved these changes
Nov 24, 2021
qmonnet
added
the
dont-merge/needs-rebase
aanm
force-pushed
the
pr/update-gh-workflows
branch
from
04b28fd
to
c7d8847
Compare
aanm
removed
the
dont-merge/needs-rebase
Some workflows need to be changed to be v1.11 specific. Also other workflows and configurations can be removed since they are only used on the master branch. To perform this task the `.github` directory from the previous stable branch was copy pasted and there was a manual check of the diff between the modified files and the files from `master` branch. Heuristically, this meant removing all GH workflows that were triggered by `issue_comment` and the ones that are exclusively cron jobs, as well as modifying the remaining workflows to be specific for this v1.11 stable branch. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/update-gh-workflows
branch
from
c7d8847
to
bbb555d
Compare
|
pushed the following diff: diff --git a/.github/workflows/lint-bpf-checks.yaml b/.github/workflows/lint-bpf-checks.yaml
index 48465af8fc..88096fe51b 100644
--- a/.github/workflows/lint-bpf-checks.yaml
+++ b/.github/workflows/lint-bpf-checks.yaml
@@ -30,7 +30,6 @@ jobs:
uses: dorny/paths-filter@b2feaf19c27470162a626bd6fa8438ae5b263721
id: changes
with:
- base: ${{ github.event.pull_request.base.sha || github.event.before }}
filters: |
bpf-tree:
- 'bpf/**'
diff --git a/.github/workflows/lint-build-commits.yaml b/.github/workflows/lint-build-commits.yaml
index 4c2cae5e02..08443038bd 100644
--- a/.github/workflows/lint-build-commits.yaml
+++ b/.github/workflows/lint-build-commits.yaml
@@ -64,7 +64,6 @@ jobs:
uses: dorny/paths-filter@b2feaf19c27470162a626bd6fa8438ae5b263721
id: bpf-tree
with:
- base: ${{ github.event.pull_request.base.sha }}
filters: |
src:
- 'bpf/**'
@@ -85,7 +84,6 @@ jobs:
uses: dorny/paths-filter@78ab00f87740f82aec8ed8826eb4c3c851044126
id: test-tree
with:
- base: ${{ github.event.pull_request.base.sha }}
filters: |
src:
- 'test/**' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some workflows need to be changed to be v1.11 specific. Also other
workflows and configurations can be removed since they are only used on
the master branch.
To perform this task the
.githubdirectory from the previous stablebranch was copy pasted and there was a manual check of the diff between
the modified files and the files from
masterbranch. Heuristically,this meant removing all GH workflows that were triggered by
issue_commentand the ones that are exclusively cron jobs, as well asmodifying the remaining workflows to be specific for this v1.11 stable
branch.
Signed-off-by: André Martins andre@cilium.io