test: align filter for kubectl.GetPodsNodes() on kubectl.GetPodsIPs() #16398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
area/CI-improvement
|
test-me-please |
qmonnet
force-pushed
the
pr/GetPodsNodes_filter
branch
from
b45aa76
to
b26137d
Compare
|
test-me-please |
joamaki
approved these changes
Jun 4, 2021
kubectl.GetPodsNodes() usage is very similar to kubectl.GetPodsIPs(), but the latter always adds a "-l " option to the generated kubectl command, avoiding the caller to pass it through as part of the filter argument. Let's align kubectl.GetPodsNodes(), for consistency. Having the "-l " in the function makes the calls more readable. It prevents the use of other selectors (e.g. "--field-selector"), but the helper is only used with label queries at the moment. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/GetPodsNodes_filter
branch
from
b26137d
to
3432e64
Compare
|
test-me-please |
nebril
approved these changes
Jun 4, 2021
jrajahalme
approved these changes
Jun 10, 2021
qmonnet
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl.GetPodsNodes()'s usage is very similar tokubectl.GetPodsIPs()'s, but the latter always adds a-loption to the generated kubectl command, avoiding the caller to pass it through as part of the filter argument.Let's align
kubectl.GetPodsNodes(), for consistency. Having the-lin the function makes the calls more readable. It prevents the use of other selectors (e.g.--field-selector), but the helper is only used with label queries at the moment.