Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: align filter for kubectl.GetPodsNodes() on kubectl.GetPodsIPs() #16398

Merged
merged 1 commit into from
Jun 11, 2021
Merged

test: align filter for kubectl.GetPodsNodes() on kubectl.GetPodsIPs() #16398

merged 1 commit into from
Jun 11, 2021
+7 −7

Commits on Jun 4, 2021

  1. test: align filter for kubectl.GetPodsNodes() on kubectl.GetPodsIPs() 

    kubectl.GetPodsNodes() usage is very similar to kubectl.GetPodsIPs(),
but the latter always adds a "-l " option to the generated kubectl
command, avoiding the caller to pass it through as part of the filter
argument.

Let's align kubectl.GetPodsNodes(), for consistency. Having the "-l " in
the function makes the calls more readable. It prevents the use of other
selectors (e.g. "--field-selector"), but the helper is only used with
label queries at the moment.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
    @qmonnet
    qmonnet committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    3432e64 View commit details
    Browse the repository at this point in the history