test: Pass container to ExecPodCmdBackground() #16435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add container option to kubectl exec to avoid test failures due to unexpected output like this:
s: "could not parse \"Defaulted container \\\"cilium-agent\\\" out of: cilium-agent, clean-cilium-state (init)\" as JSON (line 0 of \"kubectl exec -n kube-system cilium-fsfdb -- hubble observe --follow --output=json --last 1 --type l7 --from-pod 202106040737k8shubbletesthubbleobservetestl7flow/app2-58757b7dd5-4fvh7 --to-namespace 202106040737k8shubbletesthubbleobservetestl7flow --to-label id=app1,zgroup=testapp --protocol http\")",
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
kind/bug/CI
|
test-me-please |
jibi
approved these changes
Jun 4, 2021
|
Unrelated runtime test flake (change in k8s test code not affecting runtime test at all). |
|
test-1.21-4.9 had high number of test fails due to failing Istio test leaving resources behind, fixed in #16440. |
|
test-1.21-4.9 |
|
test-1.21-4.9 build was gone, re-triggering |
nebril
approved these changes
Jun 7, 2021
|
test-1.21-4.9 |
|
test-runtime |
|
test-runtime |
jrajahalme
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add container option to kubectl exec to avoid test failures due to unexpected output like this:
Signed-off-by: Jarno Rajahalme jarno@isovalent.com