test: Delete Istio resources if install does not complete #16440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Istio install fails (e.g., times out) during BeforeAll(), the resource cleanups in AfterAll() are not performed, so have to clean up explicitly after failure in BeforeAll instead. Without this some Istio resources may be left behind, causing other tests to fail due to unexpected pods being present. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
area/CI-improvement
|
test-me-please |
christarazi
approved these changes
Jun 7, 2021
|
test-1.21-4.9 |
|
test-1.21-4.9 |
|
test-1.21-4.9 |
1 similar comment
|
test-1.21-4.9 |
|
@nebril Do I need to rebase to get the CI to provision a VM? |
|
@jrajahalme I don't think so, this provisioning issue seems different then NFS ones that we were hitting. |
|
Looks like env vars were not being set properly because of |
|
test-1.21-4.9 |
|
This PR only changes a CI 2.0 (Ginkgo) and all Ginkgo CI runs passed. Marking this ready-to-merge. |
jrajahalme
added
the
ready-to-merge
jrajahalme
added
needs-backport/1.10
and removed
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Istio install fails (e.g., times out) during BeforeAll(), the
resource cleanups in AfterAll() are not performed, so have to clean up
explicitly after failure in BeforeAll instead.
Without this some Istio resources may be left behind, causing other
tests to fail due to unexpected pods being present.
Signed-off-by: Jarno Rajahalme jarno@isovalent.com