test: Instrument LB IP via BGP test with debug-events #16445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits instruments the test to save `hubble observe debug-events` output so that we can investigate the output when the test fails due to the flake[1]. [1]: cilium#16399 Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
area/CI
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
test-only --focus="K8sServicesTest.*Connectivity to endpoint via LB" --k8s_version=1.21 --kernel_version=net-next |
|
Downloaded the sysdump from the previous test run: Should be good to go. |
aanm
approved these changes
Jun 4, 2021
tklauser
approved these changes
Jun 7, 2021
christarazi
added
the
ready-to-merge
|
We have enough code approval to mark this as ready to merge. |
christarazi
added a commit
to christarazi/cilium
that referenced
this pull request
Jul 9, 2021
When inspecting a sysdump of this failing test, the expected artifacts containing the instrumentation (debug-events) are not present. This is because AfterAll is not called when the test fails. The logic should be in AfterFailed. Fixes: e63aa2b ("test: Instrument LB IP via BGP test with debug-events") Fixes: cilium#16445 Signed-off-by: Chris Tarazi <chris@isovalent.com>
kkourt
pushed a commit
that referenced
this pull request
Jul 13, 2021
When inspecting a sysdump of this failing test, the expected artifacts containing the instrumentation (debug-events) are not present. This is because AfterAll is not called when the test fails. The logic should be in AfterFailed. Fixes: e63aa2b ("test: Instrument LB IP via BGP test with debug-events") Fixes: #16445 Signed-off-by: Chris Tarazi <chris@isovalent.com>
aanm
pushed a commit
that referenced
this pull request
Jul 15, 2021
[ upstream commit 9744ff0 ] When inspecting a sysdump of this failing test, the expected artifacts containing the instrumentation (debug-events) are not present. This is because AfterAll is not called when the test fails. The logic should be in AfterFailed. Fixes: e63aa2b ("test: Instrument LB IP via BGP test with debug-events") Fixes: #16445 Signed-off-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: André Martins <andre@cilium.io>
aanm
pushed a commit
that referenced
this pull request
Jul 15, 2021
[ upstream commit 9744ff0 ] When inspecting a sysdump of this failing test, the expected artifacts containing the instrumentation (debug-events) are not present. This is because AfterAll is not called when the test fails. The logic should be in AfterFailed. Fixes: e63aa2b ("test: Instrument LB IP via BGP test with debug-events") Fixes: #16445 Signed-off-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: André Martins <andre@cilium.io>
krishgobinath
pushed a commit
to krishgobinath/cilium
that referenced
this pull request
Oct 20, 2021
When inspecting a sysdump of this failing test, the expected artifacts containing the instrumentation (debug-events) are not present. This is because AfterAll is not called when the test fails. The logic should be in AfterFailed. Fixes: e63aa2b ("test: Instrument LB IP via BGP test with debug-events") Fixes: cilium#16445 Signed-off-by: Chris Tarazi <chris@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits instruments the test to save
hubble observe debug-eventsoutput so that we can investigate the output when the test fails due to
the flake 1.
Signed-off-by: Chris Tarazi chris@isovalent.com