test: Move instrumentation to AfterFailed instead of AfterAll #16845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inspecting a sysdump of this failing test, the expected artifacts containing the instrumentation (debug-events) are not present. This is because AfterAll is not called when the test fails. The logic should be in AfterFailed. Fixes: e63aa2b ("test: Instrument LB IP via BGP test with debug-events") Fixes: cilium#16445 Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
area/CI
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
test-1.16-netnext |
jibi
approved these changes
Jul 12, 2021
|
Approving reviews are in and affected CI job has passed, marking ready to merge. |
christarazi
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting a sysdump of this failing test, the expected artifacts
containing the instrumentation (debug-events) are not present. This is
because AfterAll is not called when the test fails. The logic should be
in AfterFailed.
Fixes: e63aa2b ("test: Instrument LB IP via BGP test with debug-events")
Fixes: #16445
Signed-off-by: Chris Tarazi chris@isovalent.com