Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Update go.universe.tf/metallb #16523

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

christarazi
Copy link
Member

Following cilium/metallb#4, Cilium is now
tracking the code from the v0.9.6 branch of cilium/metallb:
https://github.com/cilium/metallb/tree/v0.9.6

This was done in a backwards-compatible way to ensure that older
versions of Cilium can still build by avoiding the invalidation of the
previous commit SHA (40d425d20241).

Signed-off-by: Chris Tarazi chris@isovalent.com

Following cilium/metallb#4, Cilium is now
tracking the code from the v0.9.6 branch of cilium/metallb:
https://github.com/cilium/metallb/tree/v0.9.6

This was done in a backwards-compatible way to ensure that older
versions of Cilium can still build by avoiding the invalidation of the
previous commit SHA (40d425d20241).

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi added sig/loadbalancing sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/misc This PR makes changes that have no direct user impact. labels Jun 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 14, 2021
@christarazi christarazi marked this pull request as ready for review June 14, 2021 18:24
@christarazi christarazi requested a review from a team as a code owner June 14, 2021 18:24
@christarazi christarazi requested a review from rolinh June 14, 2021 18:24
@christarazi
Copy link
Member Author

christarazi commented Jun 14, 2021

test-only --focus="K8sServicesTest.*Connectivity to endpoint via LB" --k8s_version=1.21 --kernel_version=net-next

Edit: This is the only test needed to validate MetalLB is working
Edit2: Looks like a transient infra level error: https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/231/

Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really hope that our patches get upstreamed so that we can get rid of this replace directive.

@christarazi
Copy link
Member Author

@rolinh It is on my to-do list, it will get done :)

@christarazi
Copy link
Member Author

christarazi commented Jun 16, 2021

test-only --focus="K8sServicesTest.*Connectivity to endpoint via LB" --k8s_version=1.21 --kernel_version=net-next

Edit: Passed

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 17, 2021
@jibi jibi merged commit 0c9d55e into cilium:master Jun 17, 2021
@christarazi christarazi deleted the pr/christarazi/update-metallb branch June 17, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants