Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EndpointSlices with BGP mode by updating MetalLB to v0.10.0 #16524

Merged
merged 4 commits into from Jul 19, 2021
Merged

Support EndpointSlices with BGP mode by updating MetalLB to v0.10.0 #16524

merged 4 commits into from Jul 19, 2021

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Jun 14, 2021 •
edited

  • bgp, vendor: Update go.universe.tf/metallb to support EndpointSlices
  • watchers: Refactor endpoint slice add/update events handling
  • bgp, watchers: Add support for EndpointSlice
  • docs, daemon: Allow EndpointSlices to be used with BGP

Depends on #16523

@christarazi christarazi added sig/loadbalancing sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jun 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 14, 2021
@christarazi christarazi changed the title pr/christarazi/endpointslices metallb Update to v0.10.0 of MetalLB for EndpointSlice support (BGP mode) Jun 14, 2021
@christarazi christarazi force-pushed the pr/christarazi/endpointslices-metallb branch from f7a52f3 to 1187e01 Compare June 18, 2021 06:10
@christarazi christarazi changed the title Update to v0.10.0 of MetalLB for EndpointSlice support (BGP mode) Support EndpointSlices with BGP mode by updating MetalLB to v0.10.0 Jun 18, 2021
@christarazi christarazi force-pushed the pr/christarazi/endpointslices-metallb branch from 1187e01 to 7015655 Compare June 18, 2021 06:15
@christarazi

This comment has been minimized.

Sign in to view
@christarazi christarazi marked this pull request as ready for review June 18, 2021 06:26
@christarazi christarazi requested a review from a team June 18, 2021 06:26
@christarazi christarazi requested a review from a team as a code owner June 18, 2021 06:26
@christarazi christarazi requested review from a team June 18, 2021 06:26
@christarazi christarazi requested a review from a team as a code owner June 18, 2021 06:26
@christarazi christarazi mentioned this pull request Jun 25, 2021
Closed
@christarazi christarazi force-pushed the pr/christarazi/endpointslices-metallb branch from 9bd3b4a to f953854 Compare June 25, 2021 17:00
@christarazi

This comment has been minimized.

Sign in to view
@christarazi christarazi force-pushed the pr/christarazi/endpointslices-metallb branch from f953854 to edbf531 Compare June 28, 2021 19:54
@christarazi

This comment has been minimized.

Sign in to view
@christarazi christarazi force-pushed the pr/christarazi/endpointslices-metallb branch from edbf531 to 06f9a34 Compare June 29, 2021 18:41
@christarazi
Copy link
Member Author

christarazi commented Jun 29, 2021 •
edited

test-me-please

Edit: Failed runs, everything else passed

  • ConformanceEKS (ci-eks)
  • ConformanceGKE (ci-gke)

@christarazi christarazi force-pushed the pr/christarazi/endpointslices-metallb branch from 06f9a34 to 77f5b28 Compare July 8, 2021 20:25
@christarazi

This comment has been minimized.

Sign in to view
@christarazi

This comment has been minimized.

Sign in to view
@christarazi christarazi force-pushed the pr/christarazi/endpointslices-metallb branch from 77f5b28 to 10937c4 Compare July 15, 2021 20:14
@christarazi
Copy link
Member Author

christarazi commented Jul 15, 2021 •
edited

Rebased to include fix for FQDN related issues (#16769) that would resolve these flakes: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/1016/

@christarazi
Copy link
Member Author

test-me-please

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 16, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.4 Jul 16, 2021
@christarazi
Copy link
Member Author

CI has passed, just need to rebase to resolve vendor conflicts:
image

@christarazi
bgp, vendor: Update go.universe.tf/metallb to support EndpointSlices
73c0a09 
This commit updates MetalLB to v0.10.0 which brings support for
EndpointSlices. Previously, we disabled EndpointSlices support in Cilium
automatically to maintain compatibility when the user requests to use
BGP mode.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
watchers: Refactor endpoint slice add/update events handling
5e5e45b 
This commit has no functional changes as it moves the add / update event
handling to a separate function. A subsequent commit will build upon
these separate functions.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
bgp, watchers: Add support for EndpointSlice
099b457 
Now that we've updated MetalLB to support EndpointSlice, this commit
adds the K8s event handling to hook up to the BGP speaker.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
docs, daemon: Allow EndpointSlices to be used with BGP
1f9752e 
Following the newly implemented support for EndpointSlices in MetalLB
v0.10.0 (https://metallb.universe.tf/release-notes/#version-0-10-0).

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/endpointslices-metallb branch from 10937c4 to 1f9752e Compare July 16, 2021 17:20
@christarazi christarazi added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jul 16, 2021
@christarazi
Copy link
Member Author

Adding back ready to merge as the vendor Go checks have passed along with Travis, which should be enough to validate the rebase.

@aanm aanm merged commit f8c0dd4 into cilium:master Jul 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.10.4 Jul 19, 2021
@christarazi christarazi deleted the pr/christarazi/endpointslices-metallb branch July 19, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@rolinh rolinh rolinh approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@christarazi @jibi @nathanjsweet @rolinh @qmonnet @aanm