test: Fix missing artifacts for tests with parentheses #16540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
kind/bug/CI
pchaigno
force-pushed
the
fix-missing-artifacts
branch
3 times, most recently
from
301b5c9
to
bb8b34e
Compare
When tests with parentheses in their name fail, the artifacts are
missing. This is happening because we run:
bash -c "zip -qr test_name.zip test_directory"
That therefore fails with:
/bin/bash: -c: line 0: syntax error near unexpected token `('
We need to add double quotes for this command to work properly with
parentheses.
Fixes: b4bfb40 ("Test: Add test result in Jenkins Junit")
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
fix-missing-artifacts
branch
from
bb8b34e
to
5527786
Compare
pchaigno
changed the title
nebril
approved these changes
Jun 17, 2021
pchaigno
added
the
ready-to-merge
|
Marking for backports as it can significantly help flake debugging. |
joestringer
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.10
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests with parentheses in their name fail, the artifacts are missing. This is happening because we run:
That therefore fails with:
We need to add double quotes for this command to work properly with parentheses.
I tested this change with a previous version of this pull request where one test was made to fail on purpose.
Before:
After:
Fixes: #15128.
Fixes: #4176.