test: Wait for cilium monitor to match expected output #15848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some tests we check the output of cilium monitor and compare it against expected substrings (e.g., allowed verdict). When doing so, we however need to repeat with a timeout until it matches as the cilium monitor output may be buffered and may not match the expected output as soon as we check. This commit fixes a couple cases where we forgot to wait for the output to match. It is expected to fix flake cilium#14676. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
pchaigno
force-pushed
the
fix-cilium-monitor-matches
branch
from
d6ffc42
to
cc10799
Compare
|
Only Runtime is required since only Runtime tests are touched. test-runtime |
nebril
approved these changes
Apr 26, 2021
This was referenced Apr 28, 2021
|
Do we need to backport this to v1.9? I believe I have just observed the issue in v1.9 backports PR #16910: |
It's hard to tell for sure because we're missing the artifacts. I've marked #16759, #16540, and #16489 for backports to ensure we have artifacts in the future.
I'm not against backporting this PR as well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some tests we check the output of
cilium monitorand compare it against expected substrings (e.g., allowed verdict). When doing so, we however need to repeat with a timeout until it matches as thecilium monitoroutput may be buffered and may not match the expected output as soon as we check. This pull request fixes a couple cases where we forgot to wait for the output to match.It is expected to fix flake #14676. See details at #14676 (comment)