Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable NFS locking #16554

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

gandro
Copy link
Member

@gandro gandro commented Jun 16, 2021

This is an attempt to fix the recent issues with NFS locking in CI, e.g.
issue #16551

From the nfs(5) manpage:

When using the nolock option, applications can lock files, but such
locks provide exclusion only against other applications running on
the same client. Remote applications are not affected by these locks.

Since in CI, we do not have any remote applications accessing the shared
folder, only using local locks should be safe and more robust than using
distributed locking.

This is an attempt to fix the recent issues with NFS locking in CI, e.g.
issue cilium#16551

From the nfs(5) manpage:

> When using the nolock option, applications can lock files, but such
> locks provide exclusion only against other applications running on
> the same client.  Remote applications are not affected by these locks.

Since in CI, we do not have any remote applications accessing the shared
folder, only using local locks should be safe and more robust than using
distributed locking.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

test-me-please

@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

test-1.20-4.19

Hit a unknown (?) but likely unrelated failure:

/home/jenkins/workspace/Cilium-PR-K8s-1.20-kernel-4.19/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:518
Cannot flush conntrack table
Expected
    <bool>: false
to be true
/home/jenkins/workspace/Cilium-PR-K8s-1.20-kernel-4.19/src/github.com/cilium/cilium/test/k8sT/DatapathConfiguration.go:859

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.19/722/testReport/junit/Suite-k8s-1/20/K8sDatapathConfig_Iptables_Skip_conntrack_for_pod_traffic/

@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

test-only --focus="K8sVerifier.Runs the kernel verifier against Cilium." --k8s_version=1.21 --kernel_version=4.9

Edit: As all other CI seems green, I will be running the above test a few times, as it is the one that was known to flake before.

Edit: Focus test passed https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/237/testReport/Suite-k8s-1/21/K8sVerifier_Runs_the_kernel_verifier_against_Cilium_s_BPF_datapath/ ✔️

@gandro gandro marked this pull request as ready for review June 16, 2021 15:15
@gandro gandro requested a review from a team as a code owner June 16, 2021 15:15
@gandro gandro requested a review from nebril June 16, 2021 15:15
@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

test-only --focus="K8sVerifier.Runs the kernel verifier against Cilium." --k8s_version=1.19 --kernel_version=5.4

Edit: Passed https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/239/testReport/Suite-k8s-1/19/K8sVerifier_Runs_the_kernel_verifier_against_Cilium_s_BPF_datapath/ ✔️

@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

test-only --focus="K8sVerifier.Runs the kernel verifier against Cilium." --k8s_version=1.21 --kernel_version=4.9

Edit: https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/240/testReport/Suite-k8s-1/21/K8sVerifier_Runs_the_kernel_verifier_against_Cilium_s_BPF_datapath/ Passed ✔️

@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

The k8s-1.16-kernel-netnext failure in looks ephemeral: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-net-next/813/

W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/focal/InRelease  Could not connect to archive.ubuntu.com:80 (2001:67c:1360:8001::23). - connect (113: No route to host) Could not connect to archive.ubuntu.com:80 (2001:67c:1360:8001::24). - connect (113: No route to host) Could not connect to archive.ubuntu.com:80 (91.189.88.152), connection timed out Could not connect to archive.ubuntu.com:80 (91.189.88.142), connection timed out [IP: 91.189.88.142 80]
W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/focal-updates/InRelease  Unable to connect to archive.ubuntu.com:http: [IP: 91.189.88.142 80]
W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/focal-backports/InRelease  Unable to connect to archive.ubuntu.com:http: [IP: 91.189.88.142 80]
W: Some index files failed to download. They have been ignored, or old ones used instead.

@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

test-only --focus="K8sVerifier.Runs the kernel verifier against Cilium." --k8s_version=1.19 --kernel_version=5.4

Edit: https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/241/testReport/Suite-k8s-1/19/K8sVerifier_Runs_the_kernel_verifier_against_Cilium_s_BPF_datapath/ passed ✔️

@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

If this passes reviews, I think this can be merged. It looks like it might fix the locking issue (it passed the flaky test 5 times so far).

@gandro
Copy link
Member Author

gandro commented Jun 16, 2021

test-only --focus="K8sVerifier.Runs the kernel verifier against Cilium." --k8s_version=1.21 --kernel_version=4.9

@gandro
Copy link
Member Author

gandro commented Jun 17, 2021

test-1.20-4.19

Edit: Meant to start test-1.16-netnext

@gandro
Copy link
Member Author

gandro commented Jun 17, 2021

test-1.16-netnext

@nebril nebril added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 17, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.9 Jul 5, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.11 Jul 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.11 Jul 15, 2021
@joestringer joestringer added this to Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@joestringer joestringer removed this from Backport pending to v1.9 in 1.9.9 Jul 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.9 in 1.9.9 Jul 19, 2021
@joestringer joestringer removed this from Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.11 Jul 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.11 Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.11
Backport done to v1.8
1.9.9
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

9 participants