v1.8 backport: ci: Disable NFS locking #16970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 1dd477d ] This is an attempt to fix the recent issues with NFS locking in CI, e.g. issue cilium#16551 From the nfs(5) manpage: > When using the nolock option, applications can lock files, but such > locks provide exclusion only against other applications running on > the same client. Remote applications are not affected by these locks. Since in CI, we do not have any remote applications accessing the shared folder, only using local locks should be safe and more robust than using distributed locking. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com> Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
maintainer-s-little-helper
bot
added
backport/1.8
kind/backports
|
test-backport-1.8 |
gandro
approved these changes
Jul 22, 2021
|
The motivation here is that it is not clear whether #16554 actually causes issues with VM provisioning. If there are no such issues in this PR, then it might be unrelated. Otherwise, we can investigate further. |
|
I'll try one more time. |
|
test-upstream-k8s |
brb
approved these changes
Jul 22, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
"test-upstream-k8s" was successful, but I will do one more just go gain additional confidence.
|
|
test-upstream-k8s |
kkourt
removed
the
ready-to-merge
|
Magical, it just passes. I don't know why I had such trouble with that PR on my prior backporting attempts. |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last 1.8 backporting round (#16912), skipped #16554 due to CI failures in the test-upstream-k8s pipeline.
This PR is a backport of just #16554.
Once this PR is merged, you can update the PR labels via: