Docs: Changed parameters for minikube start #16570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
bmcustodio
requested changes
Jun 17, 2021
|
If we merge this one, we can close #16567. |
qmonnet
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Looks good from my side (pending Bruno's comment).
Thanks for updating the spelling list, this should have been caught by the CI, but I see the Documentation test is not triggered by updates on the Charts. I created #16577 to fix that.
qmonnet
added
area/documentation
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
mauilion
force-pushed
the
docs-minikube-cni
branch
from
6d4ff03
to
afcdcaa
Compare
bmcustodio
approved these changes
Jul 5, 2021
|
I'm afraid this PR has been waiting for some time, and the first commit (to update the spelling list) is no longer relevant: It looks like |
qmonnet
added
the
dont-merge/needs-rebase
mauilion
force-pushed
the
docs-minikube-cni
branch
from
afcdcaa
to
d4f96f2
Compare
When minikube is started with `--network-plugin=cni --cni=false` the minikube cluster is started with the cni plugin configured and no cni installed. This is a better prepared cluster when the next step is to install cilium. Signed-off-by: Duffie Cooley <dcooley@isovalent.com>
mauilion
force-pushed
the
docs-minikube-cni
branch
from
d4f96f2
to
91700cc
Compare
|
Thank you! |
qmonnet
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When minikube is started with
--network-plugin=cni --cni=falsethe minikube cluster is started with the cni plugin configured and no
cni installed. This is a better prepared cluster when the next step is
to install cilium.