Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Bump cilium-cli version #16617

Merged
merged 2 commits into from
Jun 22, 2021
Merged

ci: Bump cilium-cli version #16617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c9b41
ci: Enable flow validation
nebril Jun 22, 2021
db752d6
ci: Bump cilium-cli version
nebril Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/conformance-aks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:

- name: Install Cilium CLI
run: |
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.6/cilium-linux-amd64.tar.gz
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.8.1/cilium-linux-amd64.tar.gz
sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/bin
rm cilium-linux-amd64.tar.gz

Expand Down Expand Up @@ -191,7 +191,7 @@ jobs:

- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=disabled
cilium connectivity test --flow-validation=warning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nebril Was this merged by mistake? I had understood it was added to debug a flake in this PR, but wasn't meant to be merged. It's effectively reverting #16388 which was aimed to reduce flakes until flow validation works better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I have the same question)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially since the commit does not change flow-validation in all instances, some of them are still disabled 🤔

Copy link
Member

@nbusseneau nbusseneau Jul 5, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline: am reverting to a consistent state with flow validation disabled in #16787 as per #16388, we can always switch back to any other level once we are confident the CLI has improved.


- name: Clean up Cilium
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/conformance-aws-cni.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:

- name: Install Cilium CLI
run: |
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.6/cilium-linux-amd64.tar.gz
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.8.1/cilium-linux-amd64.tar.gz
sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/bin
rm cilium-linux-amd64.tar.gz

Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test \
--flow-validation=disabled \
--flow-validation=warning \
--test '!pod-to-world-toFQDNs' # L7 policies are not supported in chaining mode.

- name: Post-test information gathering
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/conformance-eks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:

- name: Install Cilium CLI
run: |
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.6/cilium-linux-amd64.tar.gz
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.8.1/cilium-linux-amd64.tar.gz
sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/bin
rm cilium-linux-amd64.tar.gz

Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:

- name: Run connectivity test
run: |
cilium connectivity test
cilium connectivity test --flow-validation=warning

- name: Clean up Cilium
run: |
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/conformance-gke.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:

- name: Install Cilium CLI
run: |
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.6/cilium-linux-amd64.tar.gz
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.8.1/cilium-linux-amd64.tar.gz
sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/bin
rm cilium-linux-amd64.tar.gz

Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:

- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=disabled
cilium connectivity test --flow-validation=warning

- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -211,7 +211,7 @@ jobs:

- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=disabled
cilium connectivity test --flow-validation=warning

- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -244,7 +244,7 @@ jobs:

- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=disabled
cilium connectivity test --flow-validation=warning

- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -277,7 +277,7 @@ jobs:

- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=disabled
cilium connectivity test --flow-validation=warning

- name: Post-test information gathering
if: ${{ failure() }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/conformance-kind.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:

- name: Install Cilium CLI
run: |
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.6/cilium-linux-amd64.tar.gz
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.8.1/cilium-linux-amd64.tar.gz
sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/bin
rm cilium-linux-amd64.tar.gz

Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:

- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=disabled
cilium connectivity test --flow-validation=warning

- name: Clean up Cilium
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/conformance-multicluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:

- name: Install Cilium CLI
run: |
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.6/cilium-linux-amd64.tar.gz
curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.8.1/cilium-linux-amd64.tar.gz
sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/bin
rm cilium-linux-amd64.tar.gz

Expand Down Expand Up @@ -237,7 +237,7 @@ jobs:
--multi-cluster ${{ steps.contexts.outputs.context2 }} \
--test '!pod-to-nodeport' \
--test '!pod-to-local-nodeport' \
--flow-validation=disabled
--flow-validation=warning

- name: Post-test information gathering
if: ${{ failure() }}
Expand Down