workflows: fix concurrency group names #16711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
added
area/CI
nbusseneau
force-pushed
the
pr/fix-workflows-concurrency-for-labels
branch
from
28b1774
to
f73977d
Compare
pchaigno
approved these changes
Jul 1, 2021
nbusseneau
force-pushed
the
pr/fix-workflows-concurrency-for-labels
branch
from
f73977d
to
eac0a76
Compare
|
Requires #16735. Will unmark as draft once that one is merged. |
nbusseneau
force-pushed
the
pr/fix-workflows-concurrency-for-labels
branch
2 times, most recently
from
01ad081
to
ec42d21
Compare
Improve concurrency group names uniqueness, in particular for allowing testing workflow changes via `pull_request` events. In the previous version, all `pull_request`-triggered runs would end up in the same concurrency group as the `scheduled` events, due to not having a `github.event.issue` object. This new version proposes a new structure that should be unique for all types of testing, while still allowing runs of the same type to override each other: Structure: - Workflow name - Event type - A unique identifier depending on event type: - schedule: SHA - issue_comment: PR number - pull_request: PR number Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
force-pushed
the
pr/fix-workflows-concurrency-for-labels
branch
from
ec42d21
to
6cca627
Compare
pchaigno
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve concurrency group names uniqueness, in particular for allowing testing workflow changes via
pull_requestevents.In the previous version, all
pull_request-triggered runs would end up in the same concurrency group as thescheduledevents, due to not having agithub.event.issueobject.This new version proposes a new structure that should be unique for all types of testing, while still allowing runs of the same type to override each other:
Structure: