workflows: remove label filters for testing workflows #16735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used `pull_request` `labeled` events for testing changes to workflows from PRs. This was actually a remnant of our first CI 3.0 implementation to be able to run workflows on-demand rather than on every PR push, before we switched to `issue_comment` triggers. We remove the `labeled` filter as they only make it way more complicated for contributors to test workflow changes. Instead, we switch to a more simple workflow where simply uncommenting the `pull_request` trigger is enough to be able to start testing changes to a workflow. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
nbusseneau
added
area/CI
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
nbusseneau
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Sample run from this PR after uncommenting Marking as ready to review. |
tklauser
reviewed
Jul 1, 2021
nbusseneau
force-pushed
the
pr/workflows-testing
branch
from
809184d
to
41066ac
Compare
tklauser
approved these changes
Jul 1, 2021
pchaigno
approved these changes
Jul 1, 2021
pchaigno
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
pull_requestlabeledevents for testing changes to workflows from PRs. This was actually a remnant of our first CI 3.0 implementation to be able to run workflows on-demand rather than on every PR push, before we switched toissue_commenttriggers.We remove the
labeledfilter as they only make it way more complicated for contributors to test workflow changes. Instead, we switch to a more simple workflow where simply uncommenting thepull_requesttrigger is enough to be able to start testing changes to a workflow.