Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "docs: add 'endpointRoutes.enabled=true' to aws-cni" #16756

Merged
merged 1 commit into from Jul 2, 2021
Merged

Revert "docs: add 'endpointRoutes.enabled=true' to aws-cni" #16756

merged 1 commit into from Jul 2, 2021

Conversation

bmcustodio
Copy link
Contributor

This reverts commit 437e2bb. The original issue has been fixed, and hence this can be removed (c.f. #16227).

@bmcustodio
Revert "docs: add 'endpointRoutes.enabled=true' to aws-cni"
823f21b 
This reverts commit 437e2bb.
The original issue has been fixed, and hence this can be removed (c.f.
#16227).

Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
@bmcustodio bmcustodio requested review from a team as code owners July 2, 2021 11:40
@bmcustodio bmcustodio requested review from tgraf and qmonnet July 2, 2021 11:40
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 2, 2021
@bmcustodio bmcustodio added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.9 labels Jul 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.9 Jul 2, 2021
@bmcustodio bmcustodio requested a review from pchaigno July 2, 2021 11:41
pchaigno
pchaigno approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Thanks!

@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label Jul 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 2, 2021
@qmonnet
Copy link
Member

qmonnet commented Jul 2, 2021

(Shouldn't the needs-backport/1.10 label have added the PR to the 1.10.3 project? 🤔)

@pchaigno
Copy link
Member

pchaigno commented Jul 2, 2021

We've validated the change manually and have CI covering it now, so no need to wait for cilium/aws. Merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 2, 2021
@pchaigno pchaigno merged commit 8c94f11 into cilium:master Jul 2, 2021
@qmonnet qmonnet added this to Needs backport from master in 1.10.3 Jul 2, 2021
@bmcustodio bmcustodio deleted the bruno-revert-437e2bb branch July 2, 2021 14:12
@twpayne twpayne mentioned this pull request Jul 5, 2021
Merged
@twpayne twpayne mentioned this pull request Jul 5, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.9 Jul 5, 2021
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.3 Jul 15, 2021
@aanm aanm mentioned this pull request Jul 15, 2021
Merged
@joestringer joestringer added this to Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@joestringer joestringer removed this from Backport pending to v1.9 in 1.9.9 Jul 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.9 in 1.9.9 Jul 19, 2021
@joestringer joestringer removed this from Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@joestringer joestringer mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@qmonnet qmonnet qmonnet approved these changes

@tgraf tgraf Awaiting requested review from tgraf

Assignees

@tgraf tgraf

Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.3
Backport done to v1.10
1.9.9
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bmcustodio @qmonnet @pchaigno @twpayne @kkourt @joestringer @tgraf