test: Fix artifact collection for FQDN matchPattern test #16759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
kind/bug/CI
pchaigno
force-pushed
the
fqdn-fix-artifact-collection
branch
from
88fc424
to
0a4e013
Compare
twpayne
approved these changes
Jul 2, 2021
pchaigno
force-pushed
the
fqdn-fix-artifact-collection
branch
from
0a4e013
to
532f35d
Compare
pchaigno
force-pushed
the
fqdn-fix-artifact-collection
branch
from
532f35d
to
d62a42b
Compare
nebril
approved these changes
Jul 5, 2021
The file path wasn't properly escaped and therefore failed for our one
test named:
RuntimeFQDNPolicies Implements matchPattern: "*"
Fixes: d1798b3 ("Test: Add variadic argument on Node.Exec functions")
Signed-off-by: Paul Chaignon <paul@cilium.io>
Jenkins' TestDataPublishers is failing to link the artifact for this
test to the test itself in the interface, likely due to a escaping bug:
Recording test results
Attachment ad391c17_RuntimeFQDNPolicies_Implements_matchPattern:_"*".zip was referenced from the test 'Suite-runtime' but it doesn't exist. Skipping.
We can rename the test to avoid that issue.
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
fqdn-fix-artifact-collection
branch
from
d62a42b
to
9bb4cde
Compare
|
test-runtime |
|
I don't think we need the @cilium/proxy review here. Other team reviews are covered and tests are passing. Merging. |
pchaigno
added
the
ready-to-merge
|
Marking for backports as it can significantly help flake debugging. |
joestringer
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.10
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a couple artifact collection bugs. See the commits for details.
It was tested with a purposely-broken test at https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/5208/testReport/junit/(root)/Suite-runtime/RuntimeFQDNPolicies_Implements_matchPattern___/. You can see the artifact there and it also has the bugtool report. To be compared to the broken artifact collection at https://jenkins.cilium.io/job/cilium-master-runtime-kernel-4.9/2247/testReport/junit/(root)/Suite-runtime/RuntimeFQDNPolicies_Implements_matchPattern_____/.
Fixes: #16753.
Fixes: #16754.