Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "policy: Make selectorcache callbacks lock-free" #16769

Merged
merged 1 commit into from Jul 5, 2021
Merged

Revert "policy: Make selectorcache callbacks lock-free" #16769

merged 1 commit into from Jul 5, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented Jul 3, 2021 •
edited

This reverts commit a75599d.
has it seems to be causing a lot of FQDN flakes through the entire CI.

Signed-off-by: André Martins andre@cilium.io

Fixes: #16741
Fixes: #16724
Fixes: #16713
Fixes: #16659

@aanm
Revert "policy: Make selectorcache callbacks lock-free"
a34b9b8 
This reverts commit a75599d.
has it seems to be causing a lot of FQDN flakes through the entire CI.

Signed-off-by: André Martins <andre@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 3, 2021
@aanm aanm added needs-backport/1.8 release-note/misc This PR makes changes that have no direct user impact. labels Jul 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.11 Jul 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.9 Jul 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.3 Jul 3, 2021
@aanm
Copy link
Member Author

aanm commented Jul 3, 2021

test-me-please

@aanm aanm mentioned this pull request Jul 3, 2021
Closed
@aanm
Copy link
Member Author

aanm commented Jul 4, 2021

Previous jenkins failures: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/967/

@aanm
Copy link
Member Author

aanm commented Jul 4, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented Jul 4, 2021

All Jenkins jobs were green

@aanm
Copy link
Member Author

aanm commented Jul 4, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented Jul 4, 2021

All Jenkins jobs were green

@aanm
Copy link
Member Author

aanm commented Jul 4, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented Jul 4, 2021

Previous jenkins failures: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-5.4/577/

@aanm
Copy link
Member Author

aanm commented Jul 4, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented Jul 5, 2021

All Jenkins jobs were green

@aanm
Copy link
Member Author

aanm commented Jul 5, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented Jul 5, 2021

All Jenkins jobs were green

@aanm
Copy link
Member Author

aanm commented Jul 5, 2021

test-me-please

@aanm aanm requested a review from jrajahalme July 5, 2021 04:01
@aanm aanm marked this pull request as ready for review July 5, 2021 04:01
@aanm aanm requested a review from a team July 5, 2021 04:01
@pchaigno pchaigno self-requested a review July 5, 2021 08:22
@aanm aanm unassigned nebril Jul 5, 2021
@pchaigno
Copy link
Member

pchaigno commented Jul 5, 2021

The commit from https://jenkins.cilium.io/job/cilium-master-runtime-kernel-4.9/2210/ is edf76fb

Thanks for checking 🙏 Not sure why I thought #16529 was merged on the 24th :-/

We can always re-open them if they show up.

I'd rather go the other way around: leave open and close if we see it's not happening anymore. That way contributors are less likely to open a new issue for the same flake (which would mean we'd lose track of previous information unless someone notices the duplicate). I also don't see a benefit to closing the issue; it's not blocking anything.

@aanm aanm merged commit a97bd0d into cilium:master Jul 5, 2021
@aanm aanm deleted the pr/revert-sc-lock-free branch July 5, 2021 13:16
@joestringer joestringer mentioned this pull request Jul 6, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.8.11 Jul 6, 2021
@joestringer
Copy link
Member

PR #16529 was never backported to v1.8, removing the needs-backport/1.8 since you can't revert something that was never in the tree.

@christarazi christarazi mentioned this pull request Jul 7, 2021
Merged
@pchaigno pchaigno mentioned this pull request Jul 8, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.3 Jul 8, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.3 Jul 15, 2021
@aanm aanm mentioned this pull request Jul 15, 2021
Merged
@tklauser tklauser mentioned this pull request Jul 15, 2021
Merged
@jrajahalme jrajahalme mentioned this pull request Jul 15, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.9 Jul 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.9 Jul 15, 2021
@christarazi christarazi mentioned this pull request Jul 15, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.9 Jul 16, 2021
@joestringer joestringer mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees

@jrajahalme jrajahalme

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.3
Backport done to v1.10
1.9.9
Backport done to v1.9
Milestone
No milestone
5 participants
@aanm @pchaigno @joestringer @nebril @jrajahalme