change log level for lock failed: endpoint is in the process of being removed
#16773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g removed` Change the log level for `lock failed: endpoint is in the process of being removed` from error to debug Fixes: cilium#16422 Signed-off-by: Akshat Agarwal <akshat@accuknox.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
jrajahalme
approved these changes
Jul 9, 2021
| @@ -66,5 +66,5 @@ func (e *Endpoint) unconditionalRLock() { | |||
|
|
|||
| // logDisconnectedMutexAction gets the logger and logs given error with context | |||
| func (e *Endpoint) logDisconnectedMutexAction(err error, context string) { | |||
| e.getLogger().WithError(err).Error(context) | |||
| e.getLogger().WithError(err).Debug(context) | |||
There was a problem hiding this comment.
Given that this is only ever called after failing rlockAlive() and the only error condition therein is ErrNotAlive = errors.New("rlock failed: endpoint is in the process of being removed"), this is the right thing to do.
aanm
added
needs-backport/1.10
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the log level for
lock failed: endpoint is in the process of being removedfrom error to debugFixes: #16422
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.