Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change log level for lock failed: endpoint is in the process of being removed #16773

Merged
merged 1 commit into from
Jul 19, 2021
Merged

change log level for lock failed: endpoint is in the process of being removed #16773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/endpoint/lock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@ func (e *Endpoint) unconditionalRLock() {

// logDisconnectedMutexAction gets the logger and logs given error with context
func (e *Endpoint) logDisconnectedMutexAction(err error, context string) {
e.getLogger().WithError(err).Error(context)
e.getLogger().WithError(err).Debug(context)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is only ever called after failing rlockAlive() and the only error condition therein is ErrNotAlive = errors.New("rlock failed: endpoint is in the process of being removed"), this is the right thing to do.

}