New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitor: Fix mismatching frontend service debug trace types #16953
monitor: Fix mismatching frontend service debug trace types #16953
Conversation
77a3d22
to
9db81a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Left a comment about the debug msg content.
9db81a8
to
e706f37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
test-me-please |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It seems they were missed in commit 308d67f ("lb: Use more neutral terminology"). However, this was harmless as these debug types are no longer used as of commit f3c40a7 ("datapath: Do not log if svc is not found"). This commit is essentially cosmetic. Fixes: 308d67f ("lb: Use more neutral terminology") Signed-off-by: Chris Tarazi <chris@isovalent.com>
e706f37
to
00d56e5
Compare
test-me-please Job 'Cilium-PR-K8s-1.16-net-next' hit: #17176 (87.27% similarity) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, thanks!
I'll mark ready-to-merge
since the patch does not affect any run-time behavior other than monitor messages.
It seems they were missed in commit 308d67f ("lb: Use more neutral
terminology"). However, this was harmless as these debug types are no
longer used as of commit f3c40a7 ("datapath: Do not log if svc is not
found"). This commit is essentially cosmetic.
Fixes: 308d67f ("lb: Use more neutral terminology")
Signed-off-by: Chris Tarazi chris@isovalent.com