Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: Fix mismatching frontend service debug trace types #16953

Merged
merged 1 commit into from Oct 25, 2021

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Jul 21, 2021

It seems they were missed in commit 308d67f ("lb: Use more neutral
terminology"). However, this was harmless as these debug types are no
longer used as of commit f3c40a7 ("datapath: Do not log if svc is not
found"). This commit is essentially cosmetic.

Fixes: 308d67f ("lb: Use more neutral terminology")

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi christarazi added area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/misc This PR makes changes that have no direct user impact. kind/cleanup This includes no functional changes. labels Jul 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 21, 2021
@christarazi christarazi force-pushed the pr/christarazi/fix-dbg-consts branch from 77a3d22 to 9db81a8 Compare July 21, 2021 06:01
@christarazi christarazi requested a review from brb July 21, 2021 06:02
@christarazi
Copy link
Member Author

christarazi commented Jul 21, 2021

test-me-please

Edit: hit #16479, should be resolved by #16990

@christarazi christarazi marked this pull request as ready for review July 21, 2021 06:02
@christarazi christarazi requested a review from a team July 21, 2021 06:02
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Left a comment about the debug msg content.

pkg/monitor/datapath_debug.go Outdated Show resolved Hide resolved
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christarazi
Copy link
Member Author

test-me-please

@stale
Copy link

stale bot commented Aug 28, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 28, 2021
It seems they were missed in commit 308d67f ("lb: Use more neutral
terminology"). However, this was harmless as these debug types are no
longer used as of commit f3c40a7 ("datapath: Do not log if svc is not
found"). This commit is essentially cosmetic.

Fixes: 308d67f ("lb: Use more neutral terminology")

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@stale stale bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 8, 2021
@christarazi
Copy link
Member Author

christarazi commented Sep 8, 2021

test-me-please

Job 'Cilium-PR-K8s-1.16-net-next' hit: #17176 (87.27% similarity)

Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks!

I'll mark ready-to-merge since the patch does not affect any run-time behavior other than monitor messages.

@kkourt kkourt added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 25, 2021
@kkourt kkourt merged commit a1de732 into cilium:master Oct 25, 2021
@christarazi christarazi deleted the pr/christarazi/fix-dbg-consts branch October 25, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants