Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: Make L2 neighbor discovery configurable. #16974

Merged
merged 1 commit into from Jul 30, 2021
Merged

daemon: Make L2 neighbor discovery configurable. #16974

merged 1 commit into from Jul 30, 2021

Conversation

bjhaid
Copy link
Contributor

@bjhaid bjhaid commented Jul 22, 2021

This allows users who do not want cilium populating neighbor table with
mac addresses of neighbors cilium might have discovered via its
discovery process to opt out of cilium's neighbor discovery
mechanisms.

Signed-off-by: Ayodele Abejide abejideayodele@gmail.com

@bjhaid bjhaid requested review from a team July 22, 2021 14:22
@bjhaid bjhaid requested a review from a team as a code owner July 22, 2021 14:22
@bjhaid bjhaid requested review from jibi and nathanjsweet July 22, 2021 14:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 22, 2021
pkg/datapath/linux/node.go Outdated Show resolved Hide resolved
daemon/cmd/daemon_main.go Outdated Show resolved Hide resolved
@joestringer joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jul 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 22, 2021
This allows users who do not want cilium populating neighbor table with
mac addresses of neighbors cilium might have discovered via its
discovery process to opt out of cilium's neighbor discovery
mechanisms.

Signed-off-by: Ayodele Abejide <abejideayodele@gmail.com>
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brb
Copy link
Member

brb commented Jul 27, 2021

test-net-next

@aditighag
Copy link
Member

The PR introduces a new flag that's not used in any of the tests yet. Changes are simple enough - can be marked as ready for merge.

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 29, 2021
@vadorovsky vadorovsky merged commit cee08cd into cilium:master Jul 30, 2021
@brb
Copy link
Member

brb commented Jul 30, 2021

@bjhaid Thanks again for your PR. Would you mind to update the kube-proxy-replacement docs to mention the flag?

@bjhaid bjhaid deleted the l2_neigh_disc branch July 30, 2021 14:40
@bjhaid
Copy link
Contributor Author

bjhaid commented Jul 30, 2021

@bjhaid Thanks again for your PR. Would you mind to update the kube-proxy-replacement docs to mention the flag?

yes, I'll send a PR soon, need to figure out where the source for the current docs live in.

glibsm pushed a commit that referenced this pull request Sep 29, 2021
xref: #16974

Signed-off-by: Ayodele Abejide <abejideayodele@gmail.com>
glibsm pushed a commit that referenced this pull request Oct 4, 2021
[ upstream commit 0410c92 ]

xref: #16974

Signed-off-by: Ayodele Abejide <abejideayodele@gmail.com>

Signed-off-by: Glib Smaga <code@gsmaga.com>
errordeveloper pushed a commit that referenced this pull request Oct 7, 2021
[ upstream commit 0410c92 ]

xref: #16974

Signed-off-by: Ayodele Abejide <abejideayodele@gmail.com>

Signed-off-by: Glib Smaga <code@gsmaga.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants