Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add neighbor discovery behavior docs to kubeproxy-free. #17469

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Add neighbor discovery behavior docs to kubeproxy-free. #17469

merged 1 commit into from
Sep 29, 2021

Conversation

bjhaid
Copy link
Contributor

@bjhaid bjhaid commented Sep 24, 2021

xref: #16974

Signed-off-by: Ayodele Abejide abejideayodele@gmail.com

@bjhaid bjhaid requested a review from a team as a code owner September 24, 2021 17:33
@bjhaid bjhaid requested review from a team and qmonnet September 24, 2021 17:33
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 24, 2021
brb
brb requested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, just one comment.

Documentation/gettingstarted/kubeproxy-free.rst Outdated Show resolved Hide resolved
brb
brb requested changes Sep 27, 2021
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits.

Documentation/gettingstarted/kubeproxy-free.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/kubeproxy-free.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/kubeproxy-free.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/kubeproxy-free.rst Outdated Show resolved Hide resolved
brb
brb approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minus what @qmonnet said). Thanks.

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. sig/loadbalancing labels Sep 28, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 28, 2021
@qmonnet
Copy link
Member

qmonnet commented Sep 29, 2021

Checkpatch complains about the Signed-off-by tag, but it is present, just with a different name and address than the author registered from the git commit. Marking as ready to merge.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 29, 2021
@bjhaid
Add neighbor discovery behavior docs to kubeproxy-free.
e3bc20a 
xref: #16974

Signed-off-by: Ayodele Abejide <abejideayodele@gmail.com>
@bjhaid
Copy link
Contributor Author

bjhaid commented Sep 29, 2021

Checkpatch complains about the Signed-off-by tag, but it is present, just with a different name and address than the author registered from the git commit. Marking as ready to merge.

Fixed commit author/email, thanks for catching it.

@glibsm glibsm merged commit 0410c92 into cilium:master Sep 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.5 Oct 4, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.5 Oct 4, 2021
@glibsm glibsm mentioned this pull request Oct 4, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.5 Oct 13, 2021
@joestringer joestringer mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.5
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bjhaid @qmonnet @brb @glibsm @joestringer