Include '*.mesh.cilium.io' in 'clustermesh-apiserver''s server certificate. #17027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
bmcustodio
added
area/clustermesh
gandro
approved these changes
Aug 2, 2021
michi-covalent
approved these changes
Aug 2, 2021
aanm
approved these changes
Aug 2, 2021
aanm
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
qmonnet
approved these changes
Aug 3, 2021
|
test-me-please |
aanm
added
the
dont-merge/needs-rebase
Currently, the server certificate generated by Helm for 'clustermesh-apiserver' doesn't include '*.mesh.cilium.io', which is used alongside host aliases when establishing a cluster mesh. This commit addresses that by adding said domain to the list of SANs. Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
Related to the previous commit, v0.1.5 of 'cilium/certgen' adds '*.mesh.cilium.io' to the list of SANs for the server certificate generated for 'clustermesh-apiserver'. Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
|
Rebased! |
bmcustodio
removed
the
dont-merge/needs-rebase
|
test-me-please |
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.4
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.4
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the server certificate generated by Helm for
clustermesh-apiserverdoesn't include*.mesh.cilium.io, which is used alongside host aliases when establishing a cluster mesh. This PR addresses that by adding said domain to the list of SANs. It additionally brings inv0.1.5ofcilium/certgen, which adds*.mesh.cilium.ioto the list of SANs for the server certificate generated forclustermesh-apiserverwhenclustermesh.apiserver.tls.auto.methodis set tocronJob.