Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Follow-up PR] Add flag to list all avialable configurations. #17099

Closed
wants to merge 4 commits into from
Closed

[Follow-up PR] Add flag to list all avialable configurations. #17099

wants to merge 4 commits into from

Conversation

h3llix
Copy link
Contributor

@h3llix h3llix commented Aug 9, 2021

Add flag -a to list all active cilium configurations.

To be merged after #16519

@h3llix
api,cli: expose active cilium config through CLI
98c6df4 
Note: All the daemon configurations have to be public for reflections to work

Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
@h3llix
cli: add subcommand cilium config get
08dfc72 
cilium config get <config_name> gives configuration value from the cli.
conifg_name should be in kebab case.

Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
@h3llix
cli: seperate read-only and read-write configuraitons
026a3b8 
Add -r flag to show read-only configurations while default cilium config
show read-write configurations

Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
@h3llix
cli: add -a flag to list all cilium configurations
48ffe8e 
Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
@h3llix h3llix requested a review from a team August 9, 2021 09:32
@h3llix h3llix requested a review from a team as a code owner August 9, 2021 09:32
@h3llix h3llix requested a review from a team August 9, 2021 09:32
@h3llix h3llix requested a review from a team as a code owner August 9, 2021 09:32
@h3llix h3llix requested a review from a team August 9, 2021 09:32
@h3llix h3llix requested a review from a team as a code owner August 9, 2021 09:32
@h3llix h3llix requested a review from a team August 9, 2021 09:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 9, 2021
@h3llix h3llix requested review from joamaki and rolinh August 9, 2021 09:32
@h3llix h3llix requested a review from twpayne August 9, 2021 09:32
This was referenced Aug 9, 2021
Closed
Merged
@christarazi christarazi self-requested a review August 13, 2021 19:34
@pchaigno
Copy link
Member

To be merged after #16519

Let's keep this in draft mode until ready.

@pchaigno pchaigno marked this pull request as draft August 13, 2021 21:45
@h3llix h3llix closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki Awaiting requested review from joamaki

@rolinh rolinh Awaiting requested review from rolinh

@twpayne twpayne Awaiting requested review from twpayne

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet

@christarazi christarazi Awaiting requested review from christarazi

Assignees

@twpayne twpayne

@nathanjsweet nathanjsweet

@joamaki joamaki

@rolinh rolinh

@christarazi christarazi

Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@h3llix @pchaigno @twpayne @nathanjsweet @joamaki @rolinh @christarazi