Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Skip L7 test in AWS-CNI chaining mode #17122

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

pchaigno
Copy link
Member

L7 policies, including FQDN policies, are not supported in chaining mode. The Cilium CLI added a new L7 test in v0.8.6 which doesn't match our existing filtering pattern ('!fqdn'). This pull request updates the pattern to also exclude that new test.

L7 policies, including FQDN policies, are not supported in chaining
mode. The Cilium CLI added a new L7 test in v0.8.6 which doesn't match
our existing filtering pattern ('!fqdn'). This commit updates the
pattern to also exclude that new test.

Reported-by: Jarno Rajahalme <jarno@isovalent.com>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Aug 10, 2021
@pchaigno pchaigno requested review from a team as code owners August 10, 2021 12:53
@pchaigno pchaigno requested a review from tklauser August 10, 2021 12:53
@aanm
Copy link
Member

aanm commented Aug 10, 2021

ci-awscni

@pchaigno
Copy link
Member Author

The test failure is expected since it runs the master version and not the workflow code from this PR. I tested locally that cilium connectivity test --test '!fqdn,!l7' does indeed skip the L7 tests in addition to the FQDN test.

@nbusseneau
Copy link
Member

@aanm ci-awscni will run the test from master, not from this PR. To run from this PR, we'd need a temp commit with the pull_request trigger uncommented :D

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 10, 2021
@aanm aanm merged commit b54f8e0 into cilium:master Aug 10, 2021
@pchaigno pchaigno deleted the skip-l7-test-in-aws-cni branch August 10, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants