Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to list all available configurations #17303

Merged
merged 1 commit into from Oct 2, 2021

Conversation

h3llix
Copy link
Contributor

@h3llix h3llix commented Sep 3, 2021

Add flag -a to list all active cilium configurations.

@h3llix h3llix requested review from a team as code owners September 3, 2021 17:03
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 3, 2021
@michi-covalent michi-covalent added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Sep 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 3, 2021
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one minor nit.

could you also post a sample output? just curious to see how the output looks like 👀

cilium/cmd/config.go Outdated Show resolved Hide resolved
Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
@h3llix
Copy link
Contributor Author

h3llix commented Sep 3, 2021

could you also post a sample output? just curious to see how the output looks like eyes
image
image
image

Tried to show a sub-set of all configurations. But it contains all the active configurations separated by ###.

@aanm aanm changed the title [Follow-up PR] Add flag to list all avialable configurations. Add flag to list all available configurations Oct 2, 2021
@aanm aanm merged commit 85ae42e into cilium:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants