Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugtool: dump all active configs and encryption status #17304

Merged
merged 1 commit into from
Oct 2, 2021
Merged

bugtool: dump all active configs and encryption status #17304

merged 1 commit into from
Oct 2, 2021

Conversation

h3llix
Copy link
Contributor

@h3llix h3llix commented Sep 3, 2021

To be merged after #17303.

@h3llix
bugtool: dump all active configurations in bugtool
e941379 
Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
@h3llix h3llix requested a review from a team as a code owner September 3, 2021 17:12
@h3llix h3llix requested a review from ldelossa September 3, 2021 17:12
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 3, 2021
ldelossa
ldelossa reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any initial ideal on how much larger this will make a sysdump size? Ok if not, but just curious.

@kaworu kaworu added the dont-merge/blocked Another PR must be merged before this one. label Sep 10, 2021
@aanm
Copy link
Member

aanm commented Sep 15, 2021

ping @h3llix

@h3llix
Copy link
Contributor Author

h3llix commented Sep 15, 2021

Hi @aanm @ldelossa. Sorry, for being inactive as I was busy with CSAW. I'll just have a look and inform.

@h3llix
Copy link
Contributor Author

h3llix commented Sep 15, 2021

Earlier 5.1821MB, Now 5.1914MB. @ldelossa

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/blocked Another PR must be merged before this one. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 2, 2021
@aanm aanm merged commit 69c9db7 into cilium:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@h3llix @aanm @ldelossa @kaworu