New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): bandwidth-manager install error #17338
Conversation
Commit 91ee7b6fefd332e3598b341dc46a38aaa420c457 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting!
Thanks for the submission! To satisfy the bot, can you add the Signoff line from your PR into the commit message itself using |
Signed-off-by: JinLin Fu withlin@apache.org
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
FYI in future if you need it, you can use git commit -s
for --signoff and it will inject the signoff into the commit message based on your git.user configuration, then you can just configure it once and don't need to type it out each time.
fix(docs): bandwidth-manager install error
Signed-off-by: JinLin Fu withlin@apache.org