Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update cilium-cli to 0.9.1 #17464

Merged
merged 1 commit into from Sep 27, 2021
Merged

ci: update cilium-cli to 0.9.1 #17464

merged 1 commit into from Sep 27, 2021

Conversation

nebril
Copy link
Member

@nebril nebril commented Sep 24, 2021 •
edited

Let's merge this after cli 0.9.1 is released

@nebril nebril requested review from a team as code owners September 24, 2021 12:23
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 24, 2021
@nebril nebril added the release-note/ci This PR makes changes to the CI. label Sep 24, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 24, 2021
@tklauser
Copy link
Member

FYI, now that the release is actually there I've re-triggered the kind workflow which was previously failing due to the release not existing yet.

@pchaigno
Copy link
Member

We need a test commit to run the workflows with this version, right?

@nebril nebril mentioned this pull request Sep 27, 2021
Closed
@nbusseneau
Copy link
Member

nbusseneau commented Sep 27, 2021 •
edited

In the test PR we did get a DNS failure still, in https://github.com/cilium/cilium/actions/runs/1277574393 during the second connectivity test (with encryption enabled) :/

@pchaigno
Copy link
Member

DNS is always the first thing to fail when there are connectivity issues, so that's not really a distinguishing feature ;-)

I don't see any to-proxy traces in tests without proxy redirects, so I don't think those failures are the same issue.

Note the to-proxy failure may still happen in connectivity checks after IPsec (though it doesn't appear to be the case here) because, even though we reordered tests in the checks, the first few tests after enabling IPsec may still conflict with the last few tests before enabling IPsec. A fix for that could be to flush the conntrack map in between the two connectivity check runs in our workflows. Nevertheless, I'd rather wait to see how prevalent that issue is before sending such a fix.

nbusseneau
nbusseneau approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 27, 2021
@nebril
ci: update cilium-cli to 0.9.1
66732e1 
This change updates cilium-cli to 0.9.1 in github action workflows
files.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
Copy link
Member Author

nebril commented Sep 27, 2021

repushed a commit with proper formatting, bpf job was complaining about lack of commit description

@kaworu
Copy link
Member

kaworu commented Sep 27, 2021

Should this PR be marked with needs-backport/v1.10? See this PR that is going to be backported (backport PR).

@nbusseneau
Copy link
Member

Should this PR be marked with needs-backport/v1.10? See this PR that is going to be backported (backport PR).

Yes, it should be backported so that the Kind workflow uses the right CLI version.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.5 Sep 27, 2021
@jibi jibi merged commit acf3431 into cilium:master Sep 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.5 Sep 27, 2021
@kaworu kaworu mentioned this pull request Sep 27, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.5 Oct 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.5 Oct 13, 2021
@joestringer joestringer mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@joestringer joestringer joestringer approved these changes

@pchaigno pchaigno pchaigno approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@ldelossa ldelossa ldelossa approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.5
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nebril @tklauser @pchaigno @nbusseneau @kaworu @joestringer @ldelossa @michi-covalent @jibi