workflows: pin cilium-cli version to v0.8.6
#17143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #16892, we switched from pinning CLI version in workflows to using the latest stable version automatically. This can cause issues if a new release does not play nice with the set of environments tested by the workflows on `cilium/cilium`. We are reverting to pinning CLI version so as to have better control over the test environment, and avoid new CLI releases negatively impacting `cilium/cilium` workflows immediately upon release. With the CLI version pinned, any issues with the new version will be detected in the PR bumping the pinned version, allowing us to fix them prior to merging. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added
area/CI
michi-covalent
approved these changes
Aug 11, 2021
|
Link to workflow run on Kind, which uses the workflow from this PR and correctly retrieved the pinned version: https://github.com/cilium/cilium/actions/runs/1121140863 Since the changes are strictly identical on all workflows, we do not need to run any more CI. |
tklauser
approved these changes
Aug 11, 2021
pchaigno
approved these changes
Aug 11, 2021
nbusseneau
added
the
ready-to-merge
ldelossa
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16892, we switched from pinning CLI version in workflows to using the latest stable version automatically. This can cause issues if a new release does not play nice with the set of environments tested by the workflows on
cilium/cilium.We are reverting to pinning CLI version so as to have better control over the test environment, and avoid new CLI releases negatively impacting
cilium/ciliumworkflows immediately upon release.With the CLI version pinned, any issues with the new version will be detected in the PR bumping the pinned version, allowing us to fix them prior to merging.