all: remove unnecessary string(byteslice) when passed into fmt.*rintf("%s", string(b)) #17577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
Kindly cc-ing @tklauser |
tklauser
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
kkourt
reviewed
Oct 15, 2021
kkourt
approved these changes
Oct 15, 2021
…("%s", string(b))
fmt.*printf's "%s" verb converts values to strings in a performant
way so no need to cast and unnecessarily allocate byteslice->string
conversions.
Noticed from own benchmarking per
https://dashboard.github.orijtech.com/benchmark/3245b8e4bbbd44a597480319aaa4b9fe
that avoiding this unnecessary pattern can reduce time spent and
allocations by quite a big value and that showed the following
improvements:
```shell
* time/op (ns/op)
FormatIt-8 1.2µs ± 2% 1.1µs ± 10% -11.77% (p=0.000 n=10+9)
* allocs/op (MBs/op)
FormatIt-8 0.71GB/s ± 2% 0.80GB/s ± 9% +13.59% (p=0.000 n=10+9)
* allocs/op (B/op)
FormatIt-8 2.0kB ± 0% 1.1kB ± 0% -45.62% (p=0.000 n=10+10)
* allocs/op (count/op)
FormatIt-8 11 ± 0% 9.0 ± 0% -18.18% (p=0.000 n=10+10)
```
Signed-off-by: Emmanuel T Odeke <emmanuel@orijtech.com>
twpayne
added
the
ready-to-merge
odeke-em
deleted the
remove-unnecessary-string-conversion-before-fmt.rintf-percent-s
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt.*printf's "%s" verb converts values to strings in a performant
way so no need to cast and unnecessarily allocate byteslice->string
conversions.
Noticed from own benchmarking per
https://dashboard.github.orijtech.com/benchmark/3245b8e4bbbd44a597480319aaa4b9fe
that avoiding this unnecessary pattern can reduce time spent and
allocations by quite a big value and that showed the following
improvements:
Signed-off-by: Emmanuel T Odeke emmanuel@orijtech.com