docs: Remove instructions for nodeinit on various platforms #17635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The azure bridge handling code in nodeinit was previously run in every environment where nodeinit is enabled instead of only when azure.enabled was set. Move this set of code inside the azure conditional section of the template. Signed-off-by: Joe Stringer <joe@cilium.io>
* The install/kubernetes/cilium/files/nodeinit/startup.bash template file is primarily dependent on explicit nodeinit configurations for it to have any effect, eg: * .Values.nodeinit.removeCbrBridge * .Values.nodeinit.reconfigureKubelet * .Values.gke.enabled ... * .Values.azure.enabled * .Values.nodeinit.revertReconfigureKubelet * The install/kubernetes/cilium/files/nodeinit/prestop.bash template file is also similarly mainly dependent on other options, with one exception: it can delete the cilium_host device. Given that the alibaba ENI, aws-cni, AWS ENI mode, and kind installation instructions don't configure these other options, the nodeinit daemonset does not need to be installed on these systems. The only case that should differ is upon shutdown of the nodeinit DS, which doesn't fully clean up Cilium state anyway so users should use 'cilium uninstall' CLI to clean up such clusters. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
tgraf
approved these changes
Oct 22, 2021
errordeveloper
approved these changes
Oct 26, 2021
|
Only changes are docs (passing CI check) + one helm Azure change, which is not covered by helm CI, only by the cilium-cli based CI. Marking ready to merge. |
joestringer
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodeinit: Move azure bridge handing under azure.enabled
docs: Remove nodeinit instructions where unused