Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove instructions for nodeinit on various platforms #17635

Merged
merged 2 commits into from
Oct 26, 2021

Commits on Oct 18, 2021

  1. nodeinit: Move azure bridge handing under azure.enabled

    The azure bridge handling code in nodeinit was previously run in every
    environment where nodeinit is enabled instead of only when azure.enabled
    was set. Move this set of code inside the azure conditional section of the
    template.
    
    Signed-off-by: Joe Stringer <joe@cilium.io>
    joestringer committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    f9d5d8b View commit details
    Browse the repository at this point in the history
  2. docs: Remove nodeinit instructions where unused

    * The install/kubernetes/cilium/files/nodeinit/startup.bash template
      file is primarily dependent on explicit nodeinit configurations for it
      to have any effect, eg:
      * .Values.nodeinit.removeCbrBridge
      * .Values.nodeinit.reconfigureKubelet
      * .Values.gke.enabled ...
      * .Values.azure.enabled
      * .Values.nodeinit.revertReconfigureKubelet
    * The install/kubernetes/cilium/files/nodeinit/prestop.bash template
      file is also similarly mainly dependent on other options, with one
      exception: it can delete the cilium_host device.
    
    Given that the alibaba ENI, aws-cni, AWS ENI mode, and kind installation
    instructions don't configure these other options, the nodeinit daemonset
    does not need to be installed on these systems. The only case that
    should differ is upon shutdown of the nodeinit DS, which doesn't fully
    clean up Cilium state anyway so users should use 'cilium uninstall' CLI
    to clean up such clusters.
    
    Signed-off-by: Joe Stringer <joe@cilium.io>
    joestringer committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    a2eb297 View commit details
    Browse the repository at this point in the history