bpf: Refactoring egress gateway datapath #17868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
sig/datapath
pchaigno
force-pushed
the
egressgw-datapath-refactoring
branch
from
68ab33b
to
e76ec4c
Compare
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
egressgw-datapath-refactoring
branch
from
e76ec4c
to
ca13a74
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
kkourt
approved these changes
Nov 15, 2021
| @@ -13,6 +13,7 @@ | |||
| #include "lb.h" | |||
| #include "common.h" | |||
| #include "overloadable.h" | |||
| #include "egress_policies.h" | |||
There was a problem hiding this comment.
nit: are there any policies that are not egress gw policies, that could be characterized as egress policies?
There was a problem hiding this comment.
SRv6 egress policies are coming 😃
Move several check from bpf_lxc into a helper function is_cluster_destination(). Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
egressgw-datapath-refactoring
branch
from
ca13a74
to
ef858bb
Compare
|
As seen in https://github.com/cilium/cilium/compare/ca13a74c4d8fe856d34c3892df528215bc927cd6..ef858bbab4d78bdc111d35f73947a9c8d6dbdda6, the only change of the last push is a comment change. All tests were green before that, so not triggering again and keeping ready-to-merge label. |
|
Added label for backporting to v1.10 to facilitate the backport of other egress gateway fixes. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request performs just a bit of refactoring on the egress gateway's code in the datapath. This refactoring was prepared for the SRv6 work (cf. #17646) but is independent so sending it's own pull request.
See commits for details.