egressgateway: fix manager logic #17813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibi
added
release-note/bug
jibi
force-pushed
the
pr/jibi/refactor-egress-gw-manager
branch
7 times, most recently
from
6a80d9e
to
dd137a5
Compare
jibi
force-pushed
the
pr/jibi/refactor-egress-gw-manager
branch
from
dd137a5
to
5db11fe
Compare
jibi
force-pushed
the
pr/jibi/refactor-egress-gw-manager
branch
from
5db11fe
to
3a5a069
Compare
jibi
force-pushed
the
pr/jibi/refactor-egress-gw-manager
branch
2 times, most recently
from
f7faa2f
to
ebdd83b
Compare
|
/test Job 'Cilium-PR-K8s-1.20-kernel-5.4' hit: #17069 (89.67% similarity) |
joamaki
approved these changes
Nov 25, 2021
|
/test-5.4 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
pchaigno
reviewed
Nov 26, 2021
| } | ||
|
|
||
| # define lookup_ip4_egress_endpoint(sip, dip) \ | ||
| egress_lookup4(&EGRESS_MAP, sip, dip) |
There was a problem hiding this comment.
FYI, I'll have to revert all changes to this file in the SRv6 PR, except for the map/key name changes.
EDIT: Actually, I can preserve this function name change as well, doesn't make a different for SRv6 for now.
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
nbusseneau
added a commit
to nbusseneau/cilium
that referenced
this pull request
Dec 2, 2021
This backports cilium#17186 to `v1.10`. Rationale: the original PR was required on `master` for cilium#17813. cilium#18082 is backporting cilium#17813 to `v1.10`, thus it also requires similar changes. As we previously did on `master`, we switch the runtime tests to run on net-next instead of 4.9 due to new unit tests requirements. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
joestringer
pushed a commit
that referenced
this pull request
Dec 2, 2021
This backports #17186 to `v1.10`. Rationale: the original PR was required on `master` for #17813. #18082 is backporting #17813 to `v1.10`, thus it also requires similar changes. As we previously did on `master`, we switch the runtime tests to run on net-next instead of 4.9 due to new unit tests requirements. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
joestringer
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.0
Merged
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the egress gateway manager in order to provide a
single
reconcile()method, responsible for adding and removing entriesto and from the egress_policy map, that will be invoked on all events
received by the manager.
In addition to this, the manager will now wait for the k8s cache to be
fully synced before running its first reconciliation, in order to always
have the egress_policy map in a consistent state with the k8s
configuration.
Fixes: #17380
Fixes: #17753