Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon/cmd: Extend Cilium status with graceful termination config #17969

Merged
merged 1 commit into from Nov 23, 2021

Conversation

aditighag
Copy link
Member

The status only reflects the value of the flag 'enable-k8s-terminating-endpoints'. Per the (kube-proxy-replacement) documentation, the relevant feature gate still needs to be enabled in kubernetes deployments >= v1.20.

Signed-off-by: Aditi Ghag aditi@cilium.io

@aditighag aditighag added release-note/misc This PR makes changes that have no direct user impact. sig/loadbalancing labels Nov 23, 2021
@aditighag aditighag requested a review from a team November 23, 2021 06:37
@aditighag aditighag requested a review from a team as a code owner November 23, 2021 06:37
@aditighag aditighag force-pushed the pr/aditighag/extend-cilium-status branch from b8a4a09 to e1b5fbc Compare November 23, 2021 06:59
@aditighag aditighag requested a review from a team as a code owner November 23, 2021 06:59
@aditighag aditighag requested review from a team and qmonnet November 23, 2021 06:59
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm otherwise

Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo @borkmann comments - but other then this LGTM.

The status only reflects the value of the flag
'enable-k8s-terminating-endpoints'. Per the (kube-proxy-replacement)
documentation, the relevant feature gate still needs to be enabled in
kubernetes deployments >= v1.20.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag force-pushed the pr/aditighag/extend-cilium-status branch from 0bd619b to 734848e Compare November 23, 2021 21:12
@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 23, 2021
@borkmann borkmann merged commit eeb7f1b into cilium:master Nov 23, 2021
@qmonnet qmonnet mentioned this pull request Nov 26, 2021
12 tasks
@joestringer joestringer added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.11 in 1.11.0 Dec 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.11 in 1.11.0 Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.0
Backport done to v1.11
Development

Successfully merging this pull request may close these issues.

None yet

7 participants