New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon/cmd: Extend Cilium status with graceful termination config #17969
Merged
borkmann
merged 1 commit into
cilium:master
from
aditighag:pr/aditighag/extend-cilium-status
Nov 23, 2021
Merged
daemon/cmd: Extend Cilium status with graceful termination config #17969
borkmann
merged 1 commit into
cilium:master
from
aditighag:pr/aditighag/extend-cilium-status
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditighag
added
release-note/misc
This PR makes changes that have no direct user impact.
sig/loadbalancing
labels
Nov 23, 2021
aditighag
force-pushed
the
pr/aditighag/extend-cilium-status
branch
from
November 23, 2021 06:59
b8a4a09
to
e1b5fbc
Compare
borkmann
reviewed
Nov 23, 2021
borkmann
reviewed
Nov 23, 2021
borkmann
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm otherwise
rolinh
approved these changes
Nov 23, 2021
qmonnet
approved these changes
Nov 23, 2021
ldelossa
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo @borkmann comments - but other then this LGTM.
aditighag
force-pushed
the
pr/aditighag/extend-cilium-status
branch
from
November 23, 2021 21:04
e1b5fbc
to
0bd619b
Compare
The status only reflects the value of the flag 'enable-k8s-terminating-endpoints'. Per the (kube-proxy-replacement) documentation, the relevant feature gate still needs to be enabled in kubernetes deployments >= v1.20. Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/extend-cilium-status
branch
from
November 23, 2021 21:12
0bd619b
to
734848e
Compare
aditighag
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Nov 23, 2021
joestringer
added
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
and removed
backport-pending/1.11
labels
Dec 3, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.0
Dec 3, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.0
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status only reflects the value of the flag 'enable-k8s-terminating-endpoints'. Per the (kube-proxy-replacement) documentation, the relevant feature gate still needs to be enabled in kubernetes deployments >= v1.20.
Signed-off-by: Aditi Ghag aditi@cilium.io